Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize Hardtack into Hardtack Crackers #74887

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Maleclypse
Copy link
Member

Summary

None

Purpose of change

As part of #74874 this PR will increase the size of hardtack made into appropriately sized crackers. 7.6 cm x 7.6 cm x 1.26 cm.
Also includes recipes to make bite sized chunks of hardtack from crackers which age faster considering the difference between area and volume in the two sizes.

Describe the solution

Adds recipes and adds an item.

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Food / Vitamins Comestibles and drinks Crafting / Construction / Recipes Includes: Uncrafting / Disassembling json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jul 4, 2024
data/json/recipes/recipe_food.json Outdated Show resolved Hide resolved
data/json/recipes/recipe_food.json Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Jul 4, 2024
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jul 4, 2024
@Terrorforge
Copy link
Contributor

Terrorforge commented Jul 6, 2024

A piece of hardtack this size should only weigh 71 grams. Here's an article where they weighed a 3x3-inch piece of hardtack at 2.5 ounces.

This has been wrong for a long time. As discussed in #61312 many bread products have wacky density, largely due to past misuse of the stack_size trait. Fixing that is of course out of scope for this PR, but for reference here's an article discussing the density of bread more generally; at around 1 gram per cubic centimetre, hardtack is among the densest.

@Maleclypse
Copy link
Member Author

A piece of hardtack this size should only weigh 71 grams. Here's an article where they weighed a 3x3-inch piece of hardtack at 2.5 ounces.

This has been wrong for a long time. As discussed in #61312 many bread products have wacky density, largely due to past misuse of the stack_size trait. Fixing that is of course out of scope for this PR, but for reference here's an article discussing the density of bread more generally; at around 1 gram per cubic centimetre, hardtack is among the densest.

Good catch! Thanks!

@github-actions github-actions bot added the Code: Tests Measurement, self-control, statistics, balancing. label Jul 9, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants