Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate data collection and some others away from BottomError #1497

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

ClementTsang
Copy link
Owner

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Removes the BottomError::InvalidIo error type, which was mostly used for data collection and drawing, and updates the use sites.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 8.75000% with 73 lines in your changes missing coverage. Please review.

Project coverage is 40.66%. Comparing base (c56e283) to head (25fede0).

Files Patch % Lines
src/data_collection/processes/linux.rs 0.00% 59 Missing ⚠️
src/data_collection/error.rs 0.00% 6 Missing ⚠️
src/data_collection/processes/unix/user_table.rs 0.00% 3 Missing ⚠️
src/data_collection/processes.rs 0.00% 1 Missing ⚠️
src/data_collection/processes/unix.rs 0.00% 1 Missing ⚠️
src/data_collection/processes/unix/process_ext.rs 0.00% 1 Missing ⚠️
src/data_collection/processes/windows.rs 0.00% 1 Missing ⚠️
src/main.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1497       +/-   ##
===========================================
- Coverage   53.51%   40.66%   -12.86%     
===========================================
  Files         103      104        +1     
  Lines       17546    17547        +1     
===========================================
- Hits         9390     7135     -2255     
- Misses       8156    10412     +2256     
Flag Coverage Δ
macos-12 36.00% <0.00%> (-0.01%) ⬇️
ubuntu-latest 42.61% <9.09%> (-13.52%) ⬇️
windows-2019 36.13% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang merged commit 0401f52 into main Jul 22, 2024
32 of 36 checks passed
@ClementTsang ClementTsang deleted the error_refactor_pt_5 branch July 22, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant