Add macula-greek to Clear Engine mapping #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonathanrobie same as Clear-Bible/macula-hebrew#80; I'd like to merge this and create a version using cal ver ( |
|
@jacobwegner - I'd like to understand how this would relate to our other mappings - NA28, NA27, SBLGNT, etc., and how this directory relates to |
|
I also see a few likely glitches:
|
The first pass, I made assumptions about `mappings-GNT-stripped.tsv`: - That `NA1904_ID` existed on every row - That we could just add an `n` prefix This second pass ensures that we have either an `NA1904_ID` or `NA_28_ID` value per row, and we only add the `n` prefix to `NA1904_ID` if a value exists.
|
I did fix the glitches, but am closing this for now; we will revisit mappings again in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
annotationsdirectory for standoff annotations(I will circle back here and ensure we're updating the process used to create the initial mapping from https://github.com/Clear-Bible/symphony-team/pull/72)
Closes #40