Add a Hasher class #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This abstraction, which includes ByteBuf-compatible methods, also fixes the invalid-hash bug from ChunkTile.computeDataHash(), since it's not hashing the whole underlying array, only the written bytes.
Protonull
force-pushed
the
better-hashing
branch
from
713218f
to
45ab180
Compare
Gjum
approved these changes
Oct 14, 2023
Huskydog9988
approved these changes
Oct 14, 2023
mod/common/src/main/java/gjum/minecraft/mapsync/common/utils/Hasher.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This abstraction, which includes ByteBuf-compatible methods, also fixes the invalid-hash bug from ChunkTile.computeDataHash(), since it's not hashing the whole underlying array, only the written bytes.