PS-160: require superuser or official for event put delete #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to add cases for patching (contractors should be allowed to PATCH event state). |
danipran
force-pushed
the
PS-160/require-superuser-official-for-event-put-delete
branch
from
dcd2519 to
7372ce3
Compare
|
PUISTOTALKOOT-API branch is deployed to platta: https://puistotalkoot-pr165.api.dev.hel.ninja 🚀🚀🚀 |
voneiden
approved these changes
Nov 28, 2024
Merged
ReadOnly, IsOfficial and IsSuperUser Refs: PS-160, PS-159
BREAKING CHANGE: event view responds with 403/401 instead of 404 if the request has insufficient permissions or tries to access an endpoint that requires authentication BREAKING CHANGE: event update & delete requires superuser or official status (i.e. contractor cannot modify or delete their own events anymore) Refs: PS-160, PS-159
Refs: PS-160, PS-159
Refs: PS-160, PS-159
danipran
force-pushed
the
PS-160/require-superuser-official-for-event-put-delete
branch
from
7372ce3 to
c871710
Compare
|
|
PUISTOTALKOOT-API branch is deployed to platta: https://puistotalkoot-pr165.api.dev.hel.ninja 🚀🚀🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require superuser or official status for event view put/delete. This itself is a breaking change, but this also changes the response code for unauthenticated requests/requests with insufficient permissions to 401/403 (from 404).
Also refactor the tests a bit.