Add default value for description field value #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some TPR units do not have description, for example IDs 6667, 6913. For these units, the description value will be NULL. When the NULL value is rendered using `readonly_field_widget`, like here: https://github.com/City-of-Helsinki/drupal-helfi-platform-config/blob/main/modules/helfi_tpr_config/config/install/core.entity_form_display.tpr_unit.tpr_unit.default.yml#L98-L107 an error is logged from twig. The error message contains the whole render array, which can cause out of memory errors. This PR adds default empty string to description value.
|
tuutti
approved these changes
Nov 7, 2024
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some TPR units do not have description, for example IDs 6667, 6913. For these units, the description value will be NULL. When the NULL value is rendered using
readonly_field_widget, like here:https://github.com/City-of-Helsinki/drupal-helfi-platform-config/blob/main/modules/helfi_tpr_config/config/install/core.entity_form_display.tpr_unit.tpr_unit.default.yml#L98-L107,
an error is logged from twig. The error message contains the whole render array, which can cause out of memory errors.
This PR adds default empty string to description value.
How to test