Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for maintaining this helpful tool 😃 Pympress has been one of my favorite tools since I started researching as a CS graduate student a few years ago.
I made this PR with my two commits that fix two bugs each other in
master
. Sorry to include two fixes in one PR, but they are tiny and interrelated, so it'll be better to pack them.1. Layout changes not saved
As far as I confirmed, the current Pympress does not save and restore any layout changes.
How to reproduce
After applying this PR, the vertical bar position is restored as the same as 2.
2. Cannot open "Edit layout" dialog
Pympress fails to open "Edit layout" dialog in the "Starting Configuration" menu with an error message in the console.
How to reproduce
After the 3, I got a message:
I can also reproduce after the deck is closed and opened twice or more.
After this PR, the edit dialog opens without the error message.