-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor utility functions #960
base: main
Are you sure you want to change the base?
Conversation
Separate utitility functions into user manager functions and monitor control functions, disable somechecks and formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel like this is necessary. The changes here don't really improve anything.
Currently when user tries to use the user account manager commands it installs xrandr from the utility functions script. This PR separates monitor functions and user manager functions so that xrandr is not installed when trying to use user manager scripts. ( Already mentioned in PR description ) |
Is this even an issue though? |
Yes it is a wayland user getting xorg, xrandr installed automatically when trying to use the user manager is a problem.
How separating functions into their own respective module makes it confusing? Monitor functions will be inside the monitor directory and user functions will be inside user directory. Right now having two confirm actions functions and all the monitor utility related code and user manager related code in same file is more confusing. |
Type of Change
Description
Testing
Checklist