-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Do not include the feeNumerator on the collector's state.
1. The user uses this endpoint to calculate the RewardsCollector address to pass to ChorusDeposit.deposit as withdrawalCredential before deploying this RewardsCollector contract 2. The owner of FeeRewardsManager changes the defaultFeeNumerator The user would not be able to deploy the RewardsCollector at the predicted address since defaultFeeNumerator has been changed so the fees get locked in that address unless the owner changes the defaultFeeNumerator back to the value at step 1. so that the user would be able to deploy the correct RewardsCollector.
- Loading branch information
1 parent
7fb29b2
commit 28ba320
Showing
2 changed files
with
39 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters