-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for transferring multiple files #2
Commits on Jul 12, 2024
-
Add a transfer plan, transfer names and sizes
I want to be able to transfer multiple files, and I want the sender to control the file name so the receiver does not have to. This adds a step in that direction by transferring the plan, but it breaks the actual transfer. I'll fix that up next.
Configuration menu - View commit details
-
Copy full SHA for b5484f7 - Browse repository at this point
Copy the full SHA b5484f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76f6c35 - Browse repository at this point
Copy the full SHA 76f6c35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 396fcd7 - Browse repository at this point
Copy the full SHA 396fcd7View commit details -
Fix bug where file would be closed too early
For a long time I was puzzled by an "illegal seek" error. It turns out, the file was being closed becuase I dropped it immediately. The raw fd is like a borrow, I need an owned fd.
Configuration menu - View commit details
-
Copy full SHA for 5335831 - Browse repository at this point
Copy the full SHA 5335831View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5aaa23 - Browse repository at this point
Copy the full SHA d5aaa23View commit details -
Configuration menu - View commit details
-
Copy full SHA for 143a033 - Browse repository at this point
Copy the full SHA 143a033View commit details -
Make the sender stop after everything is sent
We still need to open a final connection to break the sender out of the accept() loop, but I'll do that in a follow-up commit.
Configuration menu - View commit details
-
Copy full SHA for 3d16a6e - Browse repository at this point
Copy the full SHA 3d16a6eView commit details -
Open a final connection to stop the sending side
It's a hack maybe, but I really want to avoid the async ecosystem.
Configuration menu - View commit details
-
Copy full SHA for 88986a7 - Browse repository at this point
Copy the full SHA 88986a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 893509f - Browse repository at this point
Copy the full SHA 893509fView commit details -
Allocate space for the file before we write it
Not sure if this is a good idea in the end or not, it harms debugging but creates cleaner files, which on SSDs probably does not matter but on spinning disks it can. But we use SSDs, so I am totally guilty of optimizing prematurely here.
Configuration menu - View commit details
-
Copy full SHA for cfba4cc - Browse repository at this point
Copy the full SHA cfba4ccView commit details
Commits on Jul 22, 2024
-
Add remark about sendfile mutating the offset
And that we target Linux only.
Configuration menu - View commit details
-
Copy full SHA for 66bc93a - Browse repository at this point
Copy the full SHA 66bc93aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 745dcb9 - Browse repository at this point
Copy the full SHA 745dcb9View commit details