Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directives to directive arguments #7130

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented May 29, 2024

Summary of the changes (Less than 80 chars)

  • Added directives to directive arguments.

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.45%. Comparing base (7d21ada) to head (9a8e32e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7130      +/-   ##
==========================================
- Coverage   74.27%   72.45%   -1.83%     
==========================================
  Files        2622     2625       +3     
  Lines      131762   131689      -73     
==========================================
- Hits        97864    95413    -2451     
- Misses      33898    36276    +2378     
Flag Coverage Δ
unittests 72.45% <100.00%> (-1.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glen-84 glen-84 marked this pull request as draft May 29, 2024 08:57
Copy link

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@glen-84
Copy link
Collaborator Author

glen-84 commented Jun 3, 2024

This change seems to break:

StrawberryShake/CodeGeneration/test/CodeGeneration.CSharp.Tests/SchemaGeneratorTests.cs#L28

MultipleInterfaceSchema.graphql doesn't include the listConstraint directive. If I try to add it:

directive @listConstraint(minItems: Int!) on ARGUMENT_DEFINITION

I get:

  1. The specified directive @listConstraint is not allowed on the current location ArgumentDefinition. (HotChocolate.Types.DirectiveType)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant