root: refactored msi packager to match the latest implementation #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MSI packager was intentionally left out due to its complications
and issue listed in:
wixtoolset/issues#7896
Now that the overall package job and release job are stabilized, we
can proceed to refactor MSI packager now. Hence, let's do this.
This patch refactors MSI packager to match the latest implementation
in root repository.
Co-authored-by: Shuralyov, Jean <[email protected]>
Co-authored-by: Galyna, Cory <[email protected]>
Co-authored-by: (Holloway) Chew, Kean Ho <[email protected]>
Signed-off-by: (Holloway) Chew, Kean Ho <[email protected]>
hollowaykeanho
force-pushed
the
experimental
branch
from
c62072e
to
288912c
Compare
|
development artifact removed. |
corygalyna
approved these changes
Jun 21, 2024
| @@ -0,0 +1,12 @@ | |||
| switch ($__i18n) { | |||
There was a problem hiding this comment.
What is the function of this file? If it's a leftover, please remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MSI packager was intentionally left out due to its complications and issue listed in:
wixtoolset/issues#7896
Now that the overall package job and release job are stabilized, we can proceed to refactor MSI packager now. Hence, let's do this.
This patch refactors MSI packager to match the latest implementation in root repository.