Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(cwe): add CWE infos file and logic to sarif reports #7178

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

update(cwe): add CWE infos file and logic to sarif reports #7178

wants to merge 15 commits into from

Conversation

ArturRibeiro-CX
Copy link
Contributor

@ArturRibeiro-CX ArturRibeiro-CX commented Jul 1, 2024 •
edited
Loading

Reason for Proposed Changes

  • CWE infos file was added from the Hardware and Design CWE category;

Proposed Changes

  • add Hardware-Design-CWE.csv file to assets/cwe_csv file;
  • add Research-Design-CWE.csv file to assets/cwe_csv file;
  • add new file logic to sarif reports;
  • update sarif reports unit tests with the new cwe infos;

I submit this contribution under the Apache-2.0 license.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024 •
edited
Loading

kics-logo

KICS version: v2.1.1

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 48
Queries failed to execute placeholder 0
Execution time placeholder 0

@ArturRibeiro-CX ArturRibeiro-CX marked this pull request as ready for review July 3, 2024 08:54
@ArturRibeiro-CX ArturRibeiro-CX requested a review from a team as a code owner July 3, 2024 08:54
@ArturRibeiro-CX ArturRibeiro-CX changed the title update(cwe): add hardware design CWE infos file and logic to sarif reports update(cwe): add CWE infos file and logic to sarif reports Jul 8, 2024
cx-ruiaraujo
cx-ruiaraujo approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@cx-ruiaraujo cx-ruiaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cx-ruiaraujo cx-ruiaraujo cx-ruiaraujo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ArturRibeiro-CX @cx-ruiaraujo