Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(query): add cwe infos to serverlessFW queries #7165

Merged
merged 14 commits into from
Sep 19, 2024

Conversation

ArturRibeiro-CX
Copy link
Contributor

@ArturRibeiro-CX ArturRibeiro-CX commented Jun 28, 2024

Reason for Proposed Changes

  • serverlessFW queries don't provide cwe infos;

Proposed Changes

  • add cwe infos to all serverlessFW queries;
  • add cloudProvider common to all queries;
  • fix typo on query description;

I submit this contribution under the Apache-2.0 license.

@ArturRibeiro-CX ArturRibeiro-CX requested a review from a team as a code owner June 28, 2024 10:17
@github-actions github-actions bot added the query New query feature label Jun 28, 2024
Copy link
Contributor

github-actions bot commented Jun 28, 2024

kics-logo

KICS version: v2.1.1

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 48
Queries failed to execute placeholder 0
Execution time placeholder 0

@ArturRibeiro-CX ArturRibeiro-CX marked this pull request as draft June 28, 2024 14:10
@ArturRibeiro-CX ArturRibeiro-CX marked this pull request as ready for review July 3, 2024 08:55
Copy link

gitguardian bot commented Aug 16, 2024

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
4266006 Triggered Generic Password 85af131 assets/queries/common/passwords_and_secrets/test/negative42.yaml View secret
4266006 Triggered Generic Password 85af131 assets/queries/common/passwords_and_secrets/test/negative32.yaml View secret
4266030 Triggered Generic Password 85af131 assets/queries/common/passwords_and_secrets/test/positive8.json View secret
4266030 Triggered Generic Password 85af131 assets/queries/common/passwords_and_secrets/test/positive8.json View secret
4266030 Triggered Generic Password 85af131 assets/queries/common/passwords_and_secrets/test/positive8.json View secret
4266030 Triggered Generic Password 85af131 assets/queries/common/passwords_and_secrets/test/positive8.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@ArturRibeiro-CX ArturRibeiro-CX merged commit 491d3ce into master Sep 19, 2024
26 checks passed
@ArturRibeiro-CX ArturRibeiro-CX deleted the AST-45283-serverlessFW branch September 19, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants