Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(databricks): correct databricks permissions checks #7158

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kema-dev
Copy link

@kema-dev kema-dev commented Jun 26, 2024

fix(databricks): correct databricks permissions checks

Reason for Proposed Changes

  • databricks_permissions checks were not working properly

Proposed Changes

  • Move not operator
  • Add test files (containing tests where multiple permissions are present in a single file)

Notes

  • We do not fully understand the way the not operator works, but found out that doing like so brings the desired behavior 🤷 Some more explanations would be appreciated !

I submit this contribution under the Apache-2.0 license.

@kema-dev kema-dev requested a review from a team as a code owner June 26, 2024 11:22
@github-actions github-actions bot added the community Community contribution label Jun 26, 2024
@dim-ops
Copy link
Contributor

dim-ops commented Jun 26, 2024

you forgot to update assets/queries/terraform/databricks/databricks_permissions/test/positive_expected_result.json

@dim-ops
Copy link
Contributor

dim-ops commented Jun 26, 2024

@gabriel-cx If you have an explanation, I'd be interested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants