-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(query): add CWE information to volume_has_sensitive_host_directory #7153
Conversation
Adding 668 as Exposure of Resource to Wrong Sphere seems the best fit covering both confidentiality and integrity concerns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @julianthome,
Thanks for your the contribution!
At the moment, the query metadata does not have 2 required fields, which is causing the e2e tests to fail, as you can see in the actions pipeline below.
Can you kindly add oldSeverity and cloudProvider fields to the metadata, like so:
(other query's metadata fields)
"descriptionID": "8361cc0a",
"oldSeverity": "HIGH",
"cloudProvider": "common",
"cwe": "668"
}
As soon as you do, I'll approve the PR.
Best regards.
Added missing fields
Thanks a lot @ArturRibeiro-CX ... would you mind re-checking the update. Are the changes acceptable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @julianthome,
Thanks for you contribution, those changes are enough.
We'll merge this PR as soon as possible.
Best regards.
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
4266030 | Triggered | Generic Password | b711135 | assets/queries/common/passwords_and_secrets/test/positive8.json | View secret |
4266030 | Triggered | Generic Password | b711135 | assets/queries/common/passwords_and_secrets/test/positive8.json | View secret |
4266030 | Triggered | Generic Password | b711135 | assets/queries/common/passwords_and_secrets/test/positive8.json | View secret |
4266030 | Triggered | Generic Password | b711135 | assets/queries/common/passwords_and_secrets/test/positive8.json | View secret |
4266006 | Triggered | Generic Password | b711135 | assets/queries/common/passwords_and_secrets/test/negative32.yaml | View secret |
4266006 | Triggered | Generic Password | b711135 | assets/queries/common/passwords_and_secrets/test/negative42.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Hi @julianthome, Best regards. |
** Reason for Proposed Changes**
** Proposed Changes**
I submit this contribution under the Apache-2.0 license.