Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudformation): query API Gateway V2 Stage Access Logging Settings Not Defined with FP #7139

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ArturRibeiro-CX
Copy link
Contributor

@ArturRibeiro-CX ArturRibeiro-CX commented Jun 17, 2024

Reason for Proposed Changes

  • FP due to wrong query behaviour with cloudFormation new aws protocol updates;

Proposed Changes

  • Change order of policies that evaluate AccessLogSettings to be first since DefaultRouteSettings is optional;
  • Validate if the referenced API corresponds to a WebSocket for ApiGatewayV2;
  • Check if ProtocolType value is WebSocket and if so, check DefaultRouteSettings.LoggingLevel;
  • If Api is not of type WebSocket, check AccessLogSettings;
  • Remove unit tests that didn't match the new query behaviour;
  • Add new unit tests;

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added query New query feature cloudformation CloudFormation query aws PR related with AWS Cloud labels Jun 17, 2024
Copy link
Contributor

kics-logo

KICS version: v2.1.0

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 48
Queries failed to execute placeholder 0
Execution time placeholder 0

@ArturRibeiro-CX ArturRibeiro-CX self-assigned this Jun 17, 2024
@ArturRibeiro-CX ArturRibeiro-CX marked this pull request as ready for review June 17, 2024 10:52
@ArturRibeiro-CX ArturRibeiro-CX requested a review from a team as a code owner June 17, 2024 10:52
@ArturRibeiro-CX ArturRibeiro-CX marked this pull request as draft June 17, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws PR related with AWS Cloud cloudformation CloudFormation query query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant