Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI | Improve Performance In Results Show Command (AST-70015) #928

Merged
merged 9 commits into from
Nov 12, 2024

Conversation

AlvoBen
Copy link
Collaborator

@AlvoBen AlvoBen commented Nov 6, 2024

remove second call to export service in calculating threshold

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Optimize threshold calculation to use the results we are getting in the beginning, instead of getting the results all over again.
Skip policy evaluation when agent is and IDE agent

References

https://checkmarx.atlassian.net/browse/AST-70015

Testing

added unit tests

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

remove second call to export service in calculating threshold
@AlvoBen AlvoBen requested a review from OrShamirCM as a code owner November 6, 2024 14:43
@OrShamirCM OrShamirCM requested a review from a team November 6, 2024 14:43
Copy link

github-actions bot commented Nov 10, 2024

Logo
Checkmarx One – Scan Summary & Detailsfd04478a-c2d0-4cbf-90f7-c1a3d9edd318

No New Or Fixed Issues Found

@AlvoBen AlvoBen changed the title added policy skip when agent is from plugin. CLI | Improve Performance In Results Show Command (AST-70015) Nov 10, 2024
@AlvoBen AlvoBen merged commit f28db24 into main Nov 12, 2024
9 checks passed
@AlvoBen AlvoBen deleted the other/benalvo/optimize-result-show-runtime branch November 12, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants