Support SCS Vulnerabilities in json report when Agent is VSCode/AST-CLI (AST-63907) #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Policy Management Violations
No New Or Fixed Issues Found |
AlvoBen
reviewed
Aug 27, 2024
|
Nice job! |
AlvoBen
reviewed
Aug 27, 2024
OrShamirCM
reviewed
Aug 27, 2024
This reverts commit a23cd4f.
OrShamirCM
reviewed
Aug 28, 2024
| # Extract names of failed tests and save them in the failedTests file | ||
| grep -E "^--- FAIL: " test_output.log | awk '{print $3}' > "$FAILED_TESTS_FILE" | ||
| -tags integration \ | ||
| -v \ |
There was a problem hiding this comment.
It seems like you mergred it incorrectly. this file doesn't need any changes
OrShamirCM
reviewed
Aug 28, 2024
| @@ -28,6 +28,14 @@ func GetExportPackage(exportWrapper wrappers.ExportWrapper, scanID string) (*wra | |||
| payload := &wrappers.ExportRequestPayload{ | |||
| ScanID: scanID, | |||
| FileFormat: "ScanReportJson", | |||
| ExportParameters: wrappers.ExportParameters{ | |||
| HideDevAndTestDependencies: true, | |||
OrShamirCM
reviewed
Aug 28, 2024
| @@ -26,5 +26,5 @@ type ScaTypeCollection struct { | |||
| ID string `json:"id,omitempty"` | |||
| Type string `json:"type,omitempty"` | |||
OrShamirCM
suggested changes
Aug 28, 2024
sarahCx
added a commit
that referenced
this pull request
Sep 12, 2024
Support SCS Vulnerabilities in json report when Agent is VSCode/AST-CLI (AST-63907) #850
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
Added full support for SCS engine results when scanning from the CLI.
Added partial support (only Secret Detection results) when scanning is done from VS Code
No other case SCS results are supported
References
https://checkmarx.atlassian.net/browse/AST-63907
Testing
Adding unit tests to test the following scenarios:
Scan from CLI - expect to receive all SCS engine results.
Scan from VS Code - expect to get only Secret Detection results.
Scan from another engine - expect to get no results from the SCS engine.
Scan without results from SCS.
Scan with NULL results.
Checklist