Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitLab dashboard, Dependency Scanning 0 vulnerabilities error. (AST-63985) #842

Merged
merged 7 commits into from
Aug 27, 2024

Conversation

sarahCx
Copy link
Contributor

@sarahCx sarahCx commented Aug 21, 2024

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Returning an empty array instead of NULL, to meet the requirements of the git lab results schema

References

https://checkmarx.atlassian.net/browse/AST-63985

Testing

Added an integration test to test the report file with the GitLab schema

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@OrShamirCM OrShamirCM requested a review from a team August 21, 2024 09:52
@github-actions github-actions bot added the bug Something isn't working label Aug 21, 2024
Copy link

github-actions bot commented Aug 21, 2024

Logo
Checkmarx One – Scan Summary & Details44fb9cc6-1e1c-4c76-b946-3ddc88c019a7

Policy Management Violations

Policy Name Rule(s) Break Build
[SAST-ML0] Not allowed NEW Sast vulnerabilities true

No New Or Fixed Issues Found

@AlvoBen
Copy link
Collaborator

AlvoBen commented Aug 21, 2024

Great job!

@sarahCx sarahCx merged commit 7429d28 into main Aug 27, 2024
9 checks passed
@sarahCx sarahCx deleted the bug/GLReportSchema branch August 27, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants