Merge pull request #908 from Checkmarx/bug/handlingErrors

Return correct exit code on failure (AST-57074)
Checkmarx · Oct 14, 2024 · 8bcbea2 · 8bcbea2
2 parents 7911e3f + 7cdd641
commit 8bcbea2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/internal/commands/root.go b/internal/commands/root.go
@@ -211,7 +211,6 @@ func NewAstCLI(
 		chatCmd,
 	)
 
-	rootCmd.SilenceErrors = true
 	rootCmd.SilenceUsage = true
 	return rootCmd
 }

diff --git a/internal/commands/root_test.go b/internal/commands/root_test.go
@@ -140,6 +140,13 @@ func TestFilterTagStateAndSeverityValues(t *testing.T) {
 	assert.NilError(t, err)
 }
 
+func TestCreateCommand_WithInvalidFlag_ShouldReturnExitCode1(t *testing.T) {
+	args := []string{"g"}
+	cmd := createASTTestCommand()
+	err := executeTestCommand(cmd, args...)
+	assert.Error(t, err, "unknown command \"g\" for \"cx\"")
+}
+
 func executeTestCommand(cmd *cobra.Command, args ...string) error {
 	fmt.Println("Executing command with args ", args)
 	cmd.SetArgs(args)