New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use a varint for eip155 chain IDs #11

Merged

bumblefudge merged 1 commit into ChainAgnostic:main from chunningham:fix/eip155-caip2

Sep 5, 2023

Contributor

chunningham commented Aug 10, 2023

Sets eip155 chain IDs to be varints, without a length prefix. In practice all eip155 chain IDs should be unsigned integers.


          use a varint for eip155 chain IDs, they should always be integers

d4a664c

chunningham requested a review from oed as a code owner

August 10, 2023 10:47

cla-bot bot added the cla-signed label

oed approved these changes

View reviewed changes

bumblefudge merged commit 48881a4 into ChainAgnostic:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels