Fix for PointCloudShading.normalShading parameter #12066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the PointCloudShading.normalShading parameter. Now it disables shading using normals if point cloud contains normals, but the parameter is set to false.
|
Thank you for the pull request, @YunVlad! ✅ We can confirm we have a CLA on file for you. |
Added a link to CHANGES.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the operation of the
PointCloudShading.normalShadingparameter. This parameter exists, but is not used when working withCesium3DTileset.Now if the point cloud contains normals and the
PointCloudShading.normalShadingparameter is set tofalse, the point cloud is drawn as if it did not contain normals.Issue number and link
Related Issue #11196
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change