Revisions to the 3D Tiles Next extensions #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change maximumLevel to availableLevels in implicit tiling extension
Added dedicated identifiers section
Clarfiy what it means to be an alphanumeric identifier
…nsion-revisions-groups-as-array # Conflicts: # extensions/3DTILES_metadata/schema/tileset.3DTILES_metadata.schema.json
…com/javagl/3d-tiles into extension-revisions-groups-as-array
Changed top-level groups from dictionary to array
Rename content to contents in 3DTILES_multiple_contents
3 tasks
|
@javagl This should be good for a final review and merge. There's a few remaining tasks that can be handled later. |
Disallow default and noData if required is true
javagl
reviewed
Mar 8, 2022
|
|
||
| Optionally, this extension may be used with [`3DTILES_multiple_contents`](../3DTILES_multiple_contents), organizing tile contents into groups and providing metadata for each. | ||
|
|
||
| > **Disambiguation:** This extension does not interact with the [Batch Table](../../specification/TileFormats/BatchTable) feature used by the Batched 3D Model, Instanced 3D Model, and Point Cloud formats. Instead, glTF 2.0 assets may be referenced with [`3DTILES_content_gltf`](../3DTILES_content_gltf). Metadata within these assets is enabled with the glTF extension, [`EXT_mesh_features`](https://github.com/CesiumGS/glTF/tree/3d-tiles-next/extensions/2.0/Vendor/EXT_mesh_features) using the same schema format and conventions defined here. | ||
| > **Disambiguation:** This extension does not interact with the [Batch Table](../../specification/TileFormats/BatchTable) feature used by the Batched 3D Model, Instanced 3D Model, and Point Cloud formats. Instead, glTF 2.0 assets may be referenced with [`3DTILES_content_gltf`](../3DTILES_content_gltf). Metadata within these assets is enabled with the glTF extension, [`EXT_structural_metadata`](TODO) using the same schema format and conventions defined here. |
javagl
reviewed
Mar 8, 2022
| ### Content Feature Properties | ||
|
|
||
| _This section is non-normative_ | ||
|
|
||
| Certain kinds of tile content may contain meaningful subcomponents ("features"), which may themselves be associated with metadata through more granular properties. Schemas may be embedded in these content types, but unused classes in a `3DTILES_metadata` schema are allowed, and may hint to an application that tile content might include entities instantiating those classes. | ||
|
|
||
| Assigning properties to tile content is not within the scope of this extension, but may be defined by other specifications. One such example is the glTF extension, [`EXT_mesh_features`](https://github.com/CesiumGS/glTF/tree/3d-tiles-next/extensions/2.0/Vendor/EXT_mesh_features), which supports definitions of conceptual features within geometry and textures, and associated metadata. glTF 2.0 assets with feature metadata may be included as tile contents with the [`3DTILES_content_gltf`](../3DTILES_content_gltf) extension. | ||
| Assigning properties to tile content is not within the scope of this extension, but may be defined by other specifications. One such example is the glTF extension, [`EXT_mesh_features`](https://github.com/CesiumGS/glTF/tree/3d-tiles-next/extensions/2.0/Vendor/EXT_mesh_features), which supports definitions of conceptual features within geometry and textures, and [`EXT_structural_metadata`](TODO) for associated metadata. glTF 2.0 assets with feature metadata may be included as tile contents with the [`3DTILES_content_gltf`](../3DTILES_content_gltf) extension. |
javagl
reviewed
Mar 8, 2022
specification/Metadata/README.md
Outdated
| - [Numbers](#numbers-1) | ||
| - [Scalars](#scalars-1) | ||
| - [Vectors](#vectors-1) | ||
| - [Matrices](#matrices-1) |
There was a problem hiding this comment.
Different indentation - intentional? (Also different number of # in linked-to section)
There was a problem hiding this comment.
Ah, that was not intentional. Fixed in f49d52e
javagl
reviewed
Mar 8, 2022
There was a problem hiding this comment.
Each change in this PR should already have been reviewed via the PR that went into the branch that this PR is based on. So I only did a quick ("final") pass over the changed files. There are a few places where a link links to TODO (only two of them pointed out as inlined comments - there are a few more). Will these be inserted before this is merged?
Fix links to EXT_structural_metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes revisions to many of the 3D Tiles Next extensions based on feedback since November.
offsetandscaleto remap quantized metadata to different rangesdefaultvalues for when property values are missingmaximumLeveltoavailableLevelsfor consistency withsubtreeLevelsThere have also been changes to the glTF extensions that are closely associated with 3D Tiles Next. The
EXT_mesh_featuresextension is now split into three separate extensions:EXT_mesh_featuresthat only defines the concept of feature IDsEXT_structural_metadatathat allows associating the features with metadataEXT_instance_featuresthat supports GPU instance feature IDs.For the CesiumJS implementation of these changes, see https://github.com/CesiumGS/cesium/tree/extension-revisions
Direct links to specs:
To do:
offsetandscaleclarifications: Clarification foroffsetandscaleof metadata properties #638TILESET_CRS_GEOCENTRICsemantic #633CONTENT_URIsemanticCONTENT_GROUP_IDsemanticsTILE_BOUNDING_S2_CELLsemanticTILE_MINIMUM_HEIGHTandTILE_MAXIMUM_HEIGHTto apply to S2 cells