Completion progress #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ce11an
approved these changes
Jul 6, 2024
There was a problem hiding this comment.
@WillLillis this looks great! Will get this in a build from there 🚀
P.S. If you're ever in London, let me know - I owe you a 🍺
Looking forward to taking you up on that 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heyo! I was able to spend some time working on the tree-sitter queries and completions mentioned in #2. I rewrote the cursor matching logic to take multiple lines into account, and added a few queries to give completions for
SELECTandVALUE. I haven't had time to test this super thoroughly yet, but hopefully this can help with some ideas.I can test/clean up this PR further if you're interested in merging, but I'm also happy to close if you want to just use it as a guide for when you implement this stuff yourself :)