-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: implement Neos 9 compatibility #20
base: master
Are you sure you want to change the base?
TASK: implement Neos 9 compatibility #20
Conversation
- replace `node.context.inBackend` with `renderingMode.isEdit` - replace `node.context.live` with `!renderingMode.isEdit` - replace `node.context.currentSite` with `Neos.Site.findBySiteNode(site)` - replace `Neos\ContentRepository\Domain\Model\Node` with `Neos\ContentRepository\Core\Projection\ContentGraph\Node`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by reading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thank you
Hint: depending on where and how the nodes are fetched from, the type would be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR
Could you also adjust the composer.json
?
"require": {
"neos/neos": "^9",
"carbon/eel": "^2.0"
},
@jonnitto do you have more context how Thx for the reminder @nezaniel. |
@ahaeslich Is Or is there a way to convert |
node.context.inBackend
withrenderingMode.isEdit
node.context.live
with!renderingMode.isEdit
node.context.currentSite
withNeos.Site.findBySiteNode(site)
Neos\ContentRepository\Domain\Model\Node
withNeos\ContentRepository\Core\Projection\ContentGraph\Node
related
: neos/Neos.DocsNeosIo#124