Two factor refactoring. #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 7.next-cake4 #86 +/- ##
==================================================
- Coverage 90.32% 89.98% -0.34%
- Complexity 318 344 +26
==================================================
Files 47 52 +5
Lines 775 949 +174
==================================================
+ Hits 700 854 +154
- Misses 75 95 +20 ☔ View full report in Codecov by Sentry. |
steinkel
requested changes
Feb 9, 2024
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| php-version: ['7.2', '7.3', '7.4', '8.0', '8.1'] | ||
| php-version: ['7.4', '8.0', '8.1'] |
| * | ||
| * @return bool | ||
| */ | ||
| public function enabled(): bool; |
There was a problem hiding this comment.
would it be better to use isEnabled to match with the other methods
| */ | ||
| public function build() | ||
| { | ||
| $className = Configure::read('Webauthn2fa.checker'); | ||
| $interfaces = class_implements($className); | ||
| $required = Webauthn2FAuthenticationCheckerInterface::class; | ||
| $required = Webauthn2fAuthenticationCheckerInterface::class; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract two factor logic into separate classes processing each type of 2fa.