[CBRD-25352] Add a user schema to your stored procedures for consistency with other objects #5258

jongmin-won · 2024-06-14T09:12:52Z

http://jira.cubrid.org/browse/CBRD-25352

Purpose
We will implement a feature to create a User Schema in Java Stored Procedure to ensure consistency with other objects such as tables, triggers, serial, servers, and synonyms.

Implementation
TO-DO

Remarks
AS-IS

Procedures and functions can be used by other users, independent of the owner.

CALL login ('test_user1', '') ON CLASS db_user;
CREATE FUNCTION function_hello() RETURN STRING AS LANGUAGE JAVA NAME 'SpCubrid.HelloCubrid() return java.lang.String';

CALL login ('dba', '') ON CLASS db_user;
SELECT function_hello() FROM db_root;

TO-BE

When a user other than the owner uses a procedure or function, they must specify the owner_name.

CALL login ('test_user1', '') ON CLASS db_user;
CREATE FUNCTION function_hello() RETURN STRING AS LANGUAGE JAVA NAME 'SpCubrid.HelloCubrid() return java.lang.String';

CALL login ('dba', '') ON CLASS db_user;
SELECT test_user1.function_hello() FROM db_root;

… feature/plcsql-p1n branch to add a user schema to a stored procedure.

…ditionally, class methods are system tables and do not require user_schema. ex) 'add_user', 'drop_user', 'find_user'

…Additionally, Resolves an error where the CALL PROCEDURE/FUNCTION statement does not work correctly.

…ocedure object, 2) select hello(); Modified so that [user_name.]hello is displayed when an error message occurs because the corresponding sp cannot be found during execution.

…ion user when executing a CREATE OR REPLACE PROCEDURE/FUNCTION, 2) Add user_schema to SP when performing a schema unload

…ames() to simplify it.

…d within an if-else-statement when the CALL statement is executed. 2) Added a part to remove the owner and user_schema when the unloaddb utility is executed as a general user, provided that the owner and user_schema are the same.

… 발생하도록 수정 ex) u1 사용자가 create function u2.hello 수행할 경우

…stem method 와 user method (Function& Stored_procedure) 구분을 grammar.y에서 확인하도록 수정

…st에 세션 변수가 있는 경우, csql_grammar.y에서는 세션 변수에 클래스, 객체 또는 상수 중 어떤 값이 포함되어 있는지 알 수 없습니다. 따라서, pt_bind_names()에서 java_stored_procedure가 아니고 on_call_target 값이 있으면 method로 간주하여 [user_schema]를 제거합니다.

…y value 로 잘 못 수정되는 부분 수정, 2) PT_FUNCTION 노드를 수행시 generic_name 값을 항상 downcase 하도록 수정

…x) select HELLO(); -> Query stmt: select HELLO() from dual dual

…evelop과 같이 data_type 토큰을 sp_param_type 토큰으로 변경했습니다.

ctshim · 2024-07-15T08:28:35Z

src/parser/csql_grammar.y

@@ -4092,10 +4098,10 @@ alter_stmt
 		DBG_PRINT}}
 	| ALTER				/* 1 */
 	  procedure_or_function		/* 2 */
-	  identifier				/* 3 */
+	  procedure_name			/* 3 */


이 룰에 따르면 procedure_name과 function_name을 따로 정의하면 모호하게 됩니다.
procedure_or_function_name 이라고 공통된 이름을 만드는 것이 어떤가요?
이렇게 수정을 한다면 동일하게 procedure_name_list와 function_name_list도 하나로 통합해야 할 것입니다.

좋은 코드 리뷰 감사합니다.
제 생각에도 불필요한 토큰을 사용하고 있는 것 같아서 말씀하신 것처럼 procedure_name과 function_name을 procedure_or_function_name처럼 하나로 통합했습니다.

…cedure_or_function_name token with a common name. 2) Fixed the logic when PT_DOT_ node type is changed to PT_METHOD_CALL node type when STORED_PROCEDURE is executed.

ctshim · 2024-07-18T07:05:35Z

src/parser/csql_grammar.y

+procedure_or_function_name_list
+	: procedure_or_function_name_list ',' procedure_or_function_name
+		{{
+


Suggested change

DBG_TRACE_GRAMMAR(procedure_or_function_name_list, : procedure_or_function_name_list ',' procedure_or_function_name);

Debugging을 위한 정보를 추가했습니다.

ctshim · 2024-07-18T07:05:58Z

src/parser/csql_grammar.y

+		DBG_PRINT}}
+	| procedure_or_function_name
+		{{
+


Suggested change

DBG_TRACE_GRAMMAR(procedure_or_function_name_list,| procedure_or_function_name);

Debugging을 위한 정보를 추가했습니다.

ctshim · 2024-07-18T07:13:01Z

src/parser/csql_grammar.y

@@ -12872,7 +12908,7 @@ sp_param_list
 sp_param_def
 	: identifier
 	  opt_sp_in_out
-	  data_type
+	  sp_param_type


data_type에서 sp_param_type으로 변경하면 CURSOR 같은 것도 포함되는데 의도하는 내용이 맞나요?

네 의도한 내용이 맞습니다.

이미 Develop에 적용한 내용인데, Merge 과정에서 누락된 부분이 있어 수정했습니다.

ctshim · 2024-07-18T07:27:29Z

src/object/authenticate.c

+      sprintf (new_name_str, "%s.%s", downcase_owner_name, name_str);
+
+      /* change the unique_name */
+      if (new_name_str != NULL)


new_name_str은 정적인 배열입니다. 이 체크는 의미가 없습니다.

좋은 코드 리뷰를 주셔서 감사합니다.
정적인 배열을 체크하는 부분을 제거했습니다.

ctshim · 2024-07-18T07:50:44Z

src/sp/jsp_cl.cpp

+      sm_downcase_name (owner_str, downcase_owner_name, DB_MAX_USER_LENGTH);
+      sprintf (new_name_str, "%s.%s", downcase_owner_name, sm_remove_qualifier_name (name_str));
+
+      if (new_name_str != NULL)


정적 배열입니다.

좋은 코드 리뷰를 주셔서 감사합니다.
정적인 배열을 체크하는 부분을 제거했습니다.

…re/plcsql-CBRD-25352

src/object/schema_system_catalog_install.cpp

…o pl/csql execution.

hyunikn · 2024-07-22T08:18:01Z

src/parser/name_resolution.c

+		 * If (dot.arg1->node_type == PT_NAME) & (dot.arg2->node_type == PT_FUNCTION), pt_bind_name_or_path_in_scope() always returns NULL and has an er_errid() value.
+		 * Therefore, er_errid() that occurs in pt_bind_name_or_path_in_scope must be reset.
+		 */
+		if (er_errid () == NO_ERROR)


혹시 != 를 == 로 잘못 쓰신 것 인가요.

hyunikn · 2024-07-22T09:02:21Z

src/parser/semantic_check.c

+    {
+      /* In system class names, owner name can be NULL. Otherwise, owner name must not be NULL. */
+      assert (au_is_dba_group_member (Au_user));
+      assert (sm_check_system_class_by_name (PT_NAME_ORIGINAL (name)));


sp 이름이 시스템 class/vclass 이름이라고 assert 하고 있는데, 맞는 내용인가요.

hyunikn · 2024-07-22T09:38:35Z

src/parser/parse_tree.h

@@ -540,6 +540,12 @@ struct json_t;
        || (n->node_type == PT_UPDATE && n->info.update.spec->info.spec.remote_server_name) \
        || (n->node_type == PT_MERGE && n->info.merge.into->info.spec.remote_server_name))

+#define PT_CHECK_USER_SCHEMA_PROCEDURE_OR_FUNCTION(n) \


이 매크로가 검사하는 내용에 비해 매크로의 이름이 잘 이해가 되지 않습니다.
user schema procedure or function 임을 검사하는 것이 generic_name 에 dot 이 없다는 것을 검사하는 것인가요.

hyunikn · 2024-07-22T09:47:44Z

src/parser/name_resolution.c

@@ -3245,6 +3245,19 @@ pt_bind_names (PARSER_CONTEXT * parser, PT_NODE * node, void *arg, int *continue
 	      node->info.method_call.on_call_target = node->info.method_call.arg_list;
 	      node->info.method_call.arg_list = node->info.method_call.arg_list->next;
 	      node->info.method_call.on_call_target->next = NULL;
+


회의 때 on 을 명시한 문법만 남겨 두기로 했던 것으로 기억합니다.
그렇다면, 이 if block 은 없어지게 되나요?

hyunikn · 2024-07-22T10:19:28Z

src/sp/sp_catalog.cpp

@@ -65,6 +65,7 @@ static int sp_builtin_init ()
  a.is_system_generated = true;

  // DBMS_OUTPUT.enable
+  v.unique_name = "dbms_output.enable";


dbms_output 이라는 user 가 생긴 것인가요.

Merge the code from the main development branch (CBRD-25352) into the…

76f3145

… feature/plcsql-p1n branch to add a user schema to a stored procedure.

jongmin-won self-assigned this Jun 14, 2024

jongmin-won added 8 commits June 18, 2024 09:04

Modify to execute the CALL PROCEDURE/FUNCTION statement correctly. Ad…

1ce9ff5

…ditionally, class methods are system tables and do not require user_schema. ex) 'add_user', 'drop_user', 'find_user'

Modify to execute the SELECT PROCEDURE/FUNCTION statement correctly. …

fab738a

…Additionally, Resolves an error where the CALL PROCEDURE/FUNCTION statement does not work correctly.

Merge commit 'f101fbc9c' into feature/plcsql-CBRD-25352

b2ade1d

1) Add unique_name to sp_info object to find pl/casl system stored pr…

95a96e0

…ocedure object, 2) select hello(); Modified so that [user_name.]hello is displayed when an error message occurs because the corresponding sp cannot be found during execution.

1) Resolving the issue where the OWNER is changed to the current sess…

1aeb682

…ion user when executing a CREATE OR REPLACE PROCEDURE/FUNCTION, 2) Add user_schema to SP when performing a schema unload

Modify the if-statement in the case PT_METHOD_CALL: part of pt_bind_n…

6f190ca

…ames() to simplify it.

Merge branch 'goodone' into feature/plcsql-CBRD-25352

f90eab9

jongmin-won force-pushed the feature/plcsql-CBRD-25352 branch from 8140d1b to 4fabc96 Compare July 3, 2024 04:56

jongmin-won added 2 commits July 4, 2024 17:45

Merge commit 'fe9cd5192' into feature/plcsql-CBRD-25352

1a797f1

dba 와 dba 그룹 이외 사용자가 다른 사용자의 CREATE PROCEDURE/FUNCTION 구문을 사용할 경우 에러가…

c658a6c

… 발생하도록 수정 ex) u1 사용자가 create function u2.hello 수행할 경우

jongmin-won requested review from hgryoo, hyunikn and ctshim July 5, 2024 02:05

jongmin-won marked this pull request as ready for review July 5, 2024 02:10

jongmin-won requested a review from beyondykk9 as a code owner July 5, 2024 02:10

jongmin-won added 8 commits July 9, 2024 22:10

1) test_sql 에서 error가 발생하는 case 수정(trigger_action, query_spec), 2) sy…

e2d51a1

…stem method 와 user method (Function& Stored_procedure) 구분을 grammar.y에서 확인하도록 수정

1) ALTER PROCEDURE/FUNCTION 구문에서 OWNER TO 없이 수행시 unique_name의 값이 empt…

170b14c

…y value 로 잘 못 수정되는 부분 수정, 2) PT_FUNCTION 노드를 수행시 generic_name 값을 항상 downcase 하도록 수정

[Rollback] PT_FUNCTION 노드를 수행시 generic_name 값은 사용자가 입력한 그대로 출력하게 수정 e…

df41f70

…x) select HELLO(); -> Query stmt: select HELLO() from dual dual

name_resolution 파일에 오타 수정

aca5193

name_resolution 파일에 누락된 if-statement 추가

f869886

sp_param_def 토큰 내부의 sp_param_type 토큰 위치에 data_type 토큰이 잘못 사용되었기 때문에 d…

c0fa0ff

…evelop과 같이 data_type 토큰을 sp_param_type 토큰으로 변경했습니다.

Merge commit 'c18553564' into feature/plcsql-CBRD-25352

f8ab9a0

jongmin-won mentioned this pull request Jul 15, 2024

[CBRD-25352] Add a user schema to your stored procedures for consistency with other objects CUBRID/cubrid-testcases#1768

Merged

Merge commit 'ca9beeff5' into feature/plcsql-CBRD-25352

61fb31e

ctshim reviewed Jul 15, 2024

View reviewed changes

Fixed an error where the next value of the PT_DOT node is missing

b9cae15

1) The procedure_name and function_name tokens were merged into a pro…

fc2d58a

…cedure_or_function_name token with a common name. 2) Fixed the logic when PT_DOT_ node type is changed to PT_METHOD_CALL node type when STORED_PROCEDURE is executed.

ctshim reviewed Jul 18, 2024

View reviewed changes

Merge remote-tracking branch 'upstream/feature/plcsql-p1n' into featu…

89d439b

…re/plcsql-CBRD-25352

hgryoo reviewed Jul 19, 2024

View reviewed changes

src/object/schema_system_catalog_install.cpp Outdated Show resolved Hide resolved

hgryoo reviewed Jul 19, 2024

View reviewed changes

src/object/schema_system_catalog_install.cpp Outdated Show resolved Hide resolved

jongmin-won added 2 commits July 19, 2024 17:38

Add dbms_output user_schema to CALL enable and CALL disalbe related t…

df4f051

…o pl/csql execution.

I modified it by referring to the code review.

5694430

hyunikn reviewed Jul 22, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CBRD-25352] Add a user schema to your stored procedures for consistency with other objects #5258

[CBRD-25352] Add a user schema to your stored procedures for consistency with other objects #5258

jongmin-won commented Jun 14, 2024 •

edited

Loading

ctshim Jul 15, 2024

jongmin-won Jul 22, 2024

ctshim Jul 18, 2024

jongmin-won Jul 22, 2024

ctshim Jul 18, 2024

jongmin-won Jul 22, 2024

ctshim Jul 18, 2024

jongmin-won Jul 22, 2024

ctshim Jul 18, 2024

jongmin-won Jul 22, 2024

ctshim Jul 18, 2024

jongmin-won Jul 22, 2024

hyunikn Jul 22, 2024 •

edited

Loading

hyunikn Jul 22, 2024

hyunikn Jul 22, 2024

hyunikn Jul 22, 2024

hyunikn Jul 22, 2024


	DBG_TRACE_GRAMMAR(procedure_or_function_name_list, : procedure_or_function_name_list ',' procedure_or_function_name);

[CBRD-25352] Add a user schema to your stored procedures for consistency with other objects #5258

Are you sure you want to change the base?

[CBRD-25352] Add a user schema to your stored procedures for consistency with other objects #5258

Conversation

jongmin-won commented Jun 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hyunikn Jul 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jongmin-won commented Jun 14, 2024 •

edited

Loading

hyunikn Jul 22, 2024 •

edited

Loading