Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dlt-common: add new config to remove date and time in storage header #632

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ahmetfindi
Copy link
Contributor

@ahmetfindi ahmetfindi commented May 16, 2024

Add a new OfflineTraceUseUptimeOnly toggle in dlt.conf
With this toggle you can supress real date and time from
the dlt message storage header and from offline trace filenames
This toogle is for data protection purposes.

The program was tested solely for our own use cases, which might differ from yours.
Licensed under Mozilla Public License Version 2.0

Ahmet Findikci [email protected], Mercedes-Benz Tech Innovation GmbH, imprint

@michael-methner
Copy link
Collaborator

Hello @ahmetfindi ,
thanks for your contribution. Can you remove the commit "[dlt-qnx-system: prevent unnecessary logging when buffer space is full]" from this PR as it is unrelated to the new config for date and time.

After discussion with the team, I have created the PR #635 which tries to fix dlt-qnx-system. Let's move the discussion the new PR.

Add a new OfflineTraceUseUptimeOnly toggle in dlt.conf
With this toggle you can supress real date and time from
the dlt message storage header and from offline trace filenames
This toogle is for data protection purposes.

Signed-off-by: Ahmet Findikci <[email protected]>
@ahmetfindi ahmetfindi force-pushed the dlt_offlinetrace_uptime_only branch from 5e77dae to bc04956 Compare May 24, 2024 11:33
@ahmetfindi
Copy link
Contributor Author

Hello @michael-methner
I've taken out the commit, I'll look at your PR.

@michael-methner
Copy link
Collaborator

Hello @ahmetfindi , thanks for the rework. From code review, I am fine with the change.
@minminlittleshrimp can you verify the feature before merge? Thanks.

@ahmetfindi
Copy link
Contributor Author

Hi @michael-methner @minminlittleshrimp
how do we proceed with this MR, can we merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants