Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to MOM6 input parser #6

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Fixes to MOM6 input parser #6

merged 2 commits into from
Apr 9, 2024

Conversation

micaeljtoliveira
Copy link
Collaborator

No description provided.

@micaeljtoliveira micaeljtoliveira added the bug Something isn't working label Apr 9, 2024
 - correctly handle the case of keys that were deleted.
 - change all added keys to uppercase when doing round-trip parsing, as use of uppercase is a soft convention of the MOM6 inputs.
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (366ac95) to head (7c08d32).

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          190       197    +7     
=========================================
+ Hits           190       197    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@micaeljtoliveira micaeljtoliveira self-assigned this Apr 9, 2024
@micaeljtoliveira micaeljtoliveira merged commit 13f3e9f into main Apr 9, 2024
6 checks passed
@micaeljtoliveira micaeljtoliveira deleted the fixes branch April 12, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant