Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINT-3259] Allow linking milestone on add common solution #1585

Open
wants to merge 3 commits into
base: feature/MINT-3175_mto
Choose a base branch
from

Conversation

OddTomBrooks
Copy link
Contributor

@OddTomBrooks OddTomBrooks commented Dec 26, 2024

MINT-3259

Description

This PR allows for adding milestone links when adding common solutions

How to test this change

  1. Run scripts/dev test:go and validate unit test success
  2. Run Postman endpoint to add common solution and validate that milestone links are added as expected

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@OddTomBrooks OddTomBrooks changed the base branch from main to feature/MINT-3175_mto December 26, 2024 16:53
@OddTomBrooks OddTomBrooks marked this pull request as ready for review December 27, 2024 16:14
@OddTomBrooks OddTomBrooks requested review from a team as code owners December 27, 2024 16:14
@OddTomBrooks OddTomBrooks requested review from StevenWadeOddball, garyjzhao and patrickseguraoddball and removed request for a team December 27, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant