Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set emissivity to 0.985 and set default NBGCLYR to 1 #348

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Set emissivity to 0.985 and set default NBGCLYR to 1 #348

merged 1 commit into from
Jan 19, 2021

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Jan 18, 2021

PR checklist

  • Short (1 sentence) summary of your PR:
    Set emissivity to 0.985 (was 0.95) and set default NBGCLYR to 1 (was 7)
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Full test suite run on cheyenne with 3 compilers. All tests pass but all answers change (as expected). https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks#af7e38f8107b2ec8680cf5a49d7274b43fe34248
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

See CICE-Consortium/CICE#249 for more information and history.

@eclare108213
Copy link
Contributor

Good to get this in the code soon so that @dabail10 can run the JRA-55 tests with it. Thanks!

dabail10
dabail10 approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@dabail10 dabail10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I didn't realize it was 0.985. I did my one test with 0.98, so I will have to redo it.

@apcraig apcraig merged commit 349b3f4 into CICE-Consortium:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabail10 dabail10 dabail10 approved these changes

@eclare108213 eclare108213 eclare108213 approved these changes

Assignees
No one assigned
Labels
Forcing Priority: High
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apcraig @eclare108213 @dabail10