Update for the FSD changes in icepack. #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew FSD rearrangement.
|
These look bfb, but when I compare the run logs they are different. So, this passes the QC test.
|
There was a problem hiding this comment.
The changes to the interface will cause backward compatibility problems. However there will be similar changes from elsewhere in the next release, and it's better to do them all at once.
Do you intend to update Icepack in this PR? Based on the title, I think that's correct. Please reference the corresponding Icepack PR here and describe the changes being brought in. Thanks!
16 tasks
arguments to icepack_init_fsd_bounds calls. Update calls to step_dyn_wave, step_therm2, step_therm1 to be consistent with new Icepack interfaces Clean up some blank lines Update unit test code. Update driver code including remove zsal from mct/cesm.
This needs to have the icepack hash updated.
apcraig
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ew FSD rearrangement.
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
This changes the calls to icepack_step_therm1 and icepack_step_therm2 for the FSD icepack updates.
dabail10 (D. Bailey)
Working on a QC test.
Update fsd implementation and interfaces.
This changes answers for all results due to changes in Icepack. Initial ice and snow volume values at the beginning of the lateral melt routine are now used for updating the snow and ice enthalpy as well other tracers for lateral melting.
Update fsd arguments floe_rad_l, floe_rad_c, floe_binwidth, c_fsd_range to Icepack
Update rside/fside arguments to Icepack
Update unittest and coupler layers as needed
Update Icepack to #286630f