Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone gadi (#2) #947

Merged
merged 3 commits into from
May 3, 2024
Merged

Standalone gadi (#2) #947

merged 3 commits into from
May 3, 2024

Conversation

anton-seaice
Copy link
Contributor

This is the setup for doing standalone builds on the ACCESS computers. This affects build set-up only, not CICE code.

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Add config for using cice standalone build scripts on Gadi / for ACCESS development
  • Developer(s):
    @anton-seaice
  • Suggest PR reviewers from list in the column to the right.
    @apcraig
  • Please copy the PR test results link or provide a summary of testing completed below.
    ENTER INFORMATION HERE
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

Add standalone build config for gadi supercomputer

@anton-seaice
Copy link
Contributor Author

I can't see if/how I made this fail in the CI tests:

Run cd $HOME/cice
  cd $HOME/cice
  ./cice.setup -m conda -e macos --test unittest --pes 2x1 -s helloworld --testid hw01
  cd *helloworld*hw01
  ./cice.build
  ./cice.run
  shell: /bin/csh -e {0}
 
./cice.setup:
./cice.setup: ERROR in tsfile, this should never happen
Error: Process completed with exit code 255.

@apcraig
Copy link
Contributor

apcraig commented May 1, 2024

I think github actions changed again and it's broken. UGH!!!

See also https://github.com/apcraig/CICE/actions/runs/8912669968/job/24476572429 which is just running the current CICE main (but off my fork). Will try to do some debugging.

@apcraig
Copy link
Contributor

apcraig commented May 1, 2024

Please merge/rebase from the current main head. GHActions should be working again.

@apcraig apcraig added the Porting label May 1, 2024
@apcraig apcraig self-requested a review May 1, 2024 19:58
setenv ICE_MACHINE_MACHNAME gadi
setenv ICE_MACHINE_MACHINFO "Intel Xeon Scalable"
setenv ICE_MACHINE_ENVNAME intel
# setenv ICE_MACHINE_ENVINFO ${module list}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might also have an error here. It's possible the failure you were getting was unrelated to the overall problem. If you continue to have problems, my guess is that it's because these env variables probably have to be defined. Try changing to

setenv ICE_MACHINE_ENVINFO unknown

(or similar) and see if that fixes the problem.

@apcraig
Copy link
Contributor

apcraig commented May 1, 2024

Github Actions is working again. But this PR now shows the changes associated with the merge. I think we prefer not to see those. Did you rebase? Any chance you could fix that? Another option is to create a new branch off Consortium main, merge this branches changes onto the new branch, and create a new PR. Let me know if that makes sense. Maybe you have a more clever way to handle this.

@anton-seaice anton-seaice marked this pull request as draft May 1, 2024 23:37
@anton-seaice
Copy link
Contributor Author

Thanks Tony - yes operator error. Ill fix

* Standalone gadi setup (#1)
@anton-seaice
Copy link
Contributor Author

It looks like we might have an intermittent bug in the CI:

https://github.com/ACCESS-NRI/CICE/actions/runs/8916589708 passed and https://github.com/CICE-Consortium/CICE/actions/runs/8916589961/job/24488267484 failed on the same commit !

Anyway, I made the change suggested and it passed this time (but I can't see how its related). Don't merge yet, ill have a go tomorrow at setting a more meaningful value for ICE_MACHINE_ENVINFO

@anton-seaice anton-seaice marked this pull request as ready for review May 3, 2024 03:44
@anton-seaice
Copy link
Contributor Author

This should be ready to merge @apcraig :)

@apcraig apcraig merged commit 0af031d into CICE-Consortium:main May 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants