-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix QC test, fix bug in history time axis, fix history output averaging for timestep output #624
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
441f693
Fix history features
apcraig 15763d8
revert set_nml.histall
apcraig b3364a6
fix implementation error
apcraig 96d5851
update model log output in ice_init
apcraig 7b5c2b4
Fix QC issues
apcraig c5794b4
Update testing
apcraig eaa3c3a
update documentation
apcraig e31ce7e
reset calchk to 100000 years
apcraig 83068c7
update evp1d test
apcraig 3fd897e
Merge branch 'master' of https://github.com/cice-consortium/cice into…
apcraig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the justification for removing the b4b compare with
smoke_gx3_8x2_diag1_run5day?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it fails and is expected to fail. We would have to turn on the debug flag for the baseline and test to have a chance of bit-for-bit and that would not happen for all compilers. After watching it fail a few times, I decided to just remove it. We could/should consider adding a debug version of the test though.