-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced snow physics driver #621
Merged
Merged
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
00ec763
Merge pull request #1 from CICE-Consortium/master
proteanplanet ce2c649
initial snow redist/metamorph tracer implementation (no physics)
eclare108213 41fb678
add rhosmin, snwlvlfac to namelist, change init_snow to init_snowtracers
eclare108213 a08621e
Merge branch 'master' of https://github.com/CICE-Consortium/CICE
27b60d5
Updating from Consortium CICE master
eclare108213 9ef19ce
updating format labels due to changes in Consortium master
eclare108213 7086258
add calls to new snow physics routines
eclare108213 597221b
update_state after step_snow
eclare108213 1aa9c08
fix optional in update_state
eclare108213 6a74f98
wrap step_snow and update_state with tr_snow conditional
eclare108213 fe7eabc
snow interactions with thermo (except dEdd)
eclare108213 a31f4aa
conflict warning
eclare108213 b5e9730
adding snwgrain namelist flag
eclare108213 131846f
Merge branch 'master' of https://github.com/CICE-Consortium/CICE
eclare108213 4694584
use snwredist=bulk instead of 30percent, fix array errors, init snow …
eclare108213 230d6b9
updating to v6.2
eclare108213 c1ca7ac
aging lookup table for dry metamorphism (version for testing)
eclare108213 4033f3a
add/clean up diagnostics, begin debugging restart implementation
eclare108213 71aa657
fixing restarts
eclare108213 991e6a5
add snow tests to base_suite
eclare108213 3c7b606
add history; minor cleanup
eclare108213 55fc309
fix step_therm1 interface
eclare108213 6cf44dc
Merge branch 'snow1' of https://github.com/Arctic-InteRFACE/cice
apcraig 7c70bfb
io fixes for snow1
apcraig 5c95294
Merge pull request #2 from apcraig/snow1tc1
eclare108213 bd1e892
Merge branch 'master' of https://github.com/cice-consortium/cice
eclare108213 b0ed6b7
bug fix for snow diagnostics
eclare108213 33cc32a
updating snow branch to master
eclare108213 779d077
fix line continuation
eclare108213 9493429
Merge branch 'snow1' of https://github.com/Arctic-Interface/cice into…
eclare108213 8a90b84
refactor bgc diagnostics as in Icepack
eclare108213 11e5b64
add snowtable implementation
apcraig 86c1be9
Merge pull request #3 from apcraig/snow1tc2
eclare108213 aeb9dcd
Merge branch 'master' of https://github.com/cice-consortium/cice
eclare108213 9a9b531
cleaning up snow test options
eclare108213 a5c141f
Merge branch 'master' of https://github.com/Arctic-Interface/cice int…
eclare108213 973f15c
send rsnw tracer to dEdd; initialize snow tracers; update -s options …
eclare108213 45183f5
broadcast new snow diagnostics
eclare108213 b9cca69
new snow tests require 5 snow layers and therefore can not start from…
eclare108213 33070e4
update icepack
eclare108213 fc8aefd
Merge branch 'master' of https://github.com/cice-consortium/cice into…
eclare108213 f9e7f68
use local variable for rsnow to prevent array out-of-bound error; cle…
eclare108213 8a35fe7
updating documentation and some code comments
eclare108213 c11232d
documentation: index
eclare108213 1723357
fix history output; include but comment out code for averaging based …
eclare108213 c2bc62c
minor cleanup, especially documentation
eclare108213 c3d9af3
update icepack
eclare108213 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this account for variable snow density when the tracer is turned on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly. The changes that I made to this section of the code were only refactoring for better performance and shouldn't affect the overall logic or physics/diagnostics as previously coded at all. There are quite a lot of places in the code where variable snow density could be used instead of rhos, beyond the new snow physics routines. That's a whole new science project.