-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixed 1d evp #568
Bug fixed 1d evp #568
Commits on Mar 1, 2021
-
Initialization of global HTE and HTN arrays with ghost cells on maste…
…r task to avoid gathering constant arrays when running EVP 1D implementation. This solves issue with departure errors resulting from erroneous initialization of full land blocks in EVP 1D gathering. Correct initialization of remaining variables for full land blocks in EVP 1D gathering.
Configuration menu - View commit details
-
Copy full SHA for 0ba9ddf - Browse repository at this point
Copy the full SHA 0ba9ddfView commit details
Commits on Mar 2, 2021
-
Reverted configuration/scripts/cice.batch.csh to resolve bad auto mer…
…ge of file. Machine 'freya' was double in file.
Configuration menu - View commit details
-
Copy full SHA for f5c1c1f - Browse repository at this point
Copy the full SHA f5c1c1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 17d48d8 - Browse repository at this point
Copy the full SHA 17d48d8View commit details
Commits on Mar 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b4bf34b - Browse repository at this point
Copy the full SHA b4bf34bView commit details -
Redundant initializations to default values removed (CICE-Consortium#…
…568 (comment)). @mhrib questions to default value settings removed.
Configuration menu - View commit details
-
Copy full SHA for 4b702b8 - Browse repository at this point
Copy the full SHA 4b702b8View commit details
Commits on Mar 13, 2021
-
Subroutine primary_grid_lengths_global_ext moved from ice_grid module…
… to MPI and serial implementations of ice_boundary modules (CICE-Consortium#568 (comment)). Please note duplication of subroutine.
Configuration menu - View commit details
-
Copy full SHA for a711bdc - Browse repository at this point
Copy the full SHA a711bdcView commit details
Commits on Mar 14, 2021
-
Merge pull request #14 from TillRasmussen/evp-1d
Changes requested by @eclare108213 in CICE-Consortium#568
Configuration menu - View commit details
-
Copy full SHA for d669c8d - Browse repository at this point
Copy the full SHA d669c8dView commit details
Commits on Mar 16, 2021
-
Added 1d solver to be fully integrated. Removed kevp=102 bypass.
Clean up. Changed namelist parameter kevp to evp_algorithm
Configuration menu - View commit details
-
Copy full SHA for aabb12f - Browse repository at this point
Copy the full SHA aabb12fView commit details
Commits on Mar 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1194e0c - Browse repository at this point
Copy the full SHA 1194e0cView commit details
Commits on Mar 23, 2021
-
Modified documentation in order to comply with modifications of evp 1d
Till Rasmussen committedMar 23, 2021 Configuration menu - View commit details
-
Copy full SHA for 6f11797 - Browse repository at this point
Copy the full SHA 6f11797View commit details -
Uncommenting of numainit parallelization removed and domp_init moved …
…before numainit to ensure correct initialization. Additional cleanup of code.
Configuration menu - View commit details
-
Copy full SHA for 462e7f0 - Browse repository at this point
Copy the full SHA 462e7f0View commit details -
Merge pull request #15 from TillRasmussen/evp-1d
General cleanup and corrections to parallelization
Configuration menu - View commit details
-
Copy full SHA for 8b02825 - Browse repository at this point
Copy the full SHA 8b02825View commit details -
renamed set_nml.evp_algorithm to set_nml.evp1d
added test to base test
Till Rasmussen committedMar 23, 2021 Configuration menu - View commit details
-
Copy full SHA for bc79443 - Browse repository at this point
Copy the full SHA bc79443View commit details -
Merge branch 'master' of github.com:TillRasmussen/CICE
Till Rasmussen committedMar 23, 2021 Configuration menu - View commit details
-
Copy full SHA for d0d3523 - Browse repository at this point
Copy the full SHA d0d3523View commit details -
Till Rasmussen committed
Mar 23, 2021 Configuration menu - View commit details
-
Copy full SHA for 5bb4cba - Browse repository at this point
Copy the full SHA 5bb4cbaView commit details
Commits on Mar 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 37f42d9 - Browse repository at this point
Copy the full SHA 37f42d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a5f938 - Browse repository at this point
Copy the full SHA 0a5f938View commit details
Commits on Mar 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for f624275 - Browse repository at this point
Copy the full SHA f624275View commit details
Commits on Apr 6, 2021
-
Naming of variable se is not logical. Changed to sse which is the same
as the global variable
Configuration menu - View commit details
-
Copy full SHA for 09be327 - Browse repository at this point
Copy the full SHA 09be327View commit details
Commits on Apr 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for bdc65bd - Browse repository at this point
Copy the full SHA bdc65bdView commit details
Commits on Apr 14, 2021
-
Initialization of global HTE and HTN arrays with ghost cells on maste…
…r task to avoid gathering constant arrays when running EVP 1D implementation. This solves issue with departure errors resulting from erroneous initialization of full land blocks in EVP 1D gathering. Correct initialization of remaining variables for full land blocks in EVP 1D gathering.
Configuration menu - View commit details
-
Copy full SHA for 3b8f6c7 - Browse repository at this point
Copy the full SHA 3b8f6c7View commit details -
Reverted configuration/scripts/cice.batch.csh to resolve bad auto mer…
…ge of file. Machine 'freya' was double in file.
Configuration menu - View commit details
-
Copy full SHA for ec162b2 - Browse repository at this point
Copy the full SHA ec162b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbc4832 - Browse repository at this point
Copy the full SHA cbc4832View commit details -
Redundant initializations to default values removed (CICE-Consortium#…
…568 (comment)). @mhrib questions to default value settings removed.
Configuration menu - View commit details
-
Copy full SHA for c3663ec - Browse repository at this point
Copy the full SHA c3663ecView commit details -
Subroutine primary_grid_lengths_global_ext moved from ice_grid module…
… to MPI and serial implementations of ice_boundary modules (CICE-Consortium#568 (comment)). Please note duplication of subroutine.
Configuration menu - View commit details
-
Copy full SHA for bbe2e13 - Browse repository at this point
Copy the full SHA bbe2e13View commit details -
Added 1d solver to be fully integrated. Removed kevp=102 bypass.
Clean up. Changed namelist parameter kevp to evp_algorithm
Configuration menu - View commit details
-
Copy full SHA for 15a4e9c - Browse repository at this point
Copy the full SHA 15a4e9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e7970c - Browse repository at this point
Copy the full SHA 8e7970cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cccdaa - Browse repository at this point
Copy the full SHA 6cccdaaView commit details -
Uncommenting of numainit parallelization removed and domp_init moved …
…before numainit to ensure correct initialization. Additional cleanup of code.
Configuration menu - View commit details
-
Copy full SHA for 462ed9e - Browse repository at this point
Copy the full SHA 462ed9eView commit details -
renamed set_nml.evp_algorithm to set_nml.evp1d
added test to base test
Configuration menu - View commit details
-
Copy full SHA for 6b97cf0 - Browse repository at this point
Copy the full SHA 6b97cf0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08debdc - Browse repository at this point
Copy the full SHA 08debdcView commit details -
Naming of variable se is not logical. Changed to sse which is the same
as the global variable
Configuration menu - View commit details
-
Copy full SHA for 2f849ed - Browse repository at this point
Copy the full SHA 2f849edView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3b00e4 - Browse repository at this point
Copy the full SHA e3b00e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2f49f9 - Browse repository at this point
Copy the full SHA e2f49f9View commit details
Commits on Jul 11, 2021
-
Fix bad scaling of calculation of tinyarea. Different order of multip…
…lication causes small differences in result
Configuration menu - View commit details
-
Copy full SHA for e4bedb4 - Browse repository at this point
Copy the full SHA e4bedb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb2b3ed - Browse repository at this point
Copy the full SHA fb2b3edView commit details
Commits on Jul 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3eb47b2 - Browse repository at this point
Copy the full SHA 3eb47b2View commit details -
- There are relatively rare cases/gridcells where stress (tmask) and stepu (umask) are advanced without the other. The 1d evp implementation was not addressing this issue, so skiptcell was added to the 1d evp (similar to skipucell) to mask out cells separately for stress and stepu. This fixed a few non bit-for-bit cases in testing. - Cleaned up some indentation and other minor issues in 1d evp. - Updated the evp_algorithm log output in ice_init.
Configuration menu - View commit details
-
Copy full SHA for 1262455 - Browse repository at this point
Copy the full SHA 1262455View commit details
Commits on Jul 17, 2021
-
Merge pull request #17 from apcraig/evp1da
Fix evp 1d masking issues
Configuration menu - View commit details
-
Copy full SHA for 064bc47 - Browse repository at this point
Copy the full SHA 064bc47View commit details -
Some minor revisions in the documentation as suggested by @apcraig (C…
…ICE-Consortium#568 (review)) plus some additional minor spelling corrections.
Configuration menu - View commit details
-
Copy full SHA for 1869e93 - Browse repository at this point
Copy the full SHA 1869e93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92c49bb - Browse repository at this point
Copy the full SHA 92c49bbView commit details