Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixed 1d evp #568

Merged
merged 41 commits into from
Aug 5, 2021
Merged

Bug fixed 1d evp #568

merged 41 commits into from
Aug 5, 2021

Commits on Mar 1, 2021

  1. Initialization of global HTE and HTN arrays with ghost cells on maste…

    …r task to avoid gathering constant arrays when running EVP 1D implementation. This solves issue with departure errors resulting from erroneous initialization of full land blocks in EVP 1D gathering. Correct initialization of remaining variables for full land blocks in EVP 1D gathering.
    srethmeier committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    0ba9ddf View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. Reverted configuration/scripts/cice.batch.csh to resolve bad auto mer…

    …ge of file. Machine 'freya' was double in file.
    srethmeier committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    f5c1c1f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    17d48d8 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. Configuration menu
    Copy the full SHA
    b4bf34b View commit details
    Browse the repository at this point in the history
  2. Redundant initializations to default values removed (CICE-Consortium#…

    …568 (comment)). @mhrib questions to default value settings removed.
    srethmeier committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    4b702b8 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2021

  1. Subroutine primary_grid_lengths_global_ext moved from ice_grid module…

    … to MPI and serial implementations of ice_boundary modules (CICE-Consortium#568 (comment)). Please note duplication of subroutine.
    srethmeier committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    a711bdc View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2021

  1. Configuration menu
    Copy the full SHA
    d669c8d View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Added 1d solver to be fully integrated. Removed kevp=102 bypass.

    Clean up. Changed namelist parameter kevp to evp_algorithm
    TillRasmussen committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    aabb12f View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2021

  1. Configuration menu
    Copy the full SHA
    1194e0c View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2021

  1. Configuration menu
    Copy the full SHA
    6f11797 View commit details
    Browse the repository at this point in the history
  2. Uncommenting of numainit parallelization removed and domp_init moved …

    …before numainit to ensure correct initialization. Additional cleanup of code.
    srethmeier committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    462e7f0 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #15 from TillRasmussen/evp-1d

    General cleanup and corrections to parallelization
    TillRasmussen authored Mar 23, 2021
    Configuration menu
    Copy the full SHA
    8b02825 View commit details
    Browse the repository at this point in the history
  4. renamed set_nml.evp_algorithm to set_nml.evp1d

    added test to base test
    Till Rasmussen committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    bc79443 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'master' of github.com:TillRasmussen/CICE

    Till Rasmussen committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    d0d3523 View commit details
    Browse the repository at this point in the history
  6. rm set_nml.kevp102

    Till Rasmussen committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    5bb4cba View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2021

  1. Configuration menu
    Copy the full SHA
    37f42d9 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'evp-1d'

    srethmeier committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    0a5f938 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2021

  1. Configuration menu
    Copy the full SHA
    f624275 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. Configuration menu
    Copy the full SHA
    09be327 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. Configuration menu
    Copy the full SHA
    bdc65bd View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2021

  1. Initialization of global HTE and HTN arrays with ghost cells on maste…

    …r task to avoid gathering constant arrays when running EVP 1D implementation. This solves issue with departure errors resulting from erroneous initialization of full land blocks in EVP 1D gathering. Correct initialization of remaining variables for full land blocks in EVP 1D gathering.
    srethmeier authored and TillRasmussen committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    3b8f6c7 View commit details
    Browse the repository at this point in the history
  2. Reverted configuration/scripts/cice.batch.csh to resolve bad auto mer…

    …ge of file. Machine 'freya' was double in file.
    srethmeier authored and TillRasmussen committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    ec162b2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cbc4832 View commit details
    Browse the repository at this point in the history
  4. Redundant initializations to default values removed (CICE-Consortium#…

    …568 (comment)). @mhrib questions to default value settings removed.
    srethmeier authored and TillRasmussen committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    c3663ec View commit details
    Browse the repository at this point in the history
  5. Subroutine primary_grid_lengths_global_ext moved from ice_grid module…

    … to MPI and serial implementations of ice_boundary modules (CICE-Consortium#568 (comment)). Please note duplication of subroutine.
    srethmeier authored and TillRasmussen committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    bbe2e13 View commit details
    Browse the repository at this point in the history
  6. Added 1d solver to be fully integrated. Removed kevp=102 bypass.

    Clean up. Changed namelist parameter kevp to evp_algorithm
    TillRasmussen committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    15a4e9c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8e7970c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6cccdaa View commit details
    Browse the repository at this point in the history
  9. Uncommenting of numainit parallelization removed and domp_init moved …

    …before numainit to ensure correct initialization. Additional cleanup of code.
    srethmeier authored and TillRasmussen committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    462ed9e View commit details
    Browse the repository at this point in the history
  10. renamed set_nml.evp_algorithm to set_nml.evp1d

    added test to base test
    Till Rasmussen authored and TillRasmussen committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    6b97cf0 View commit details
    Browse the repository at this point in the history
  11. rm set_nml.kevp102

    Till Rasmussen authored and TillRasmussen committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    08debdc View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    2f849ed View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    e3b00e4 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    e2f49f9 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2021

  1. Fix bad scaling of calculation of tinyarea. Different order of multip…

    …lication causes small differences in result
    TillRasmussen committed Jul 11, 2021
    Configuration menu
    Copy the full SHA
    e4bedb4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fb2b3ed View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2021

  1. Configuration menu
    Copy the full SHA
    3eb47b2 View commit details
    Browse the repository at this point in the history
  2. Fix evp 1d masking issues

    - There are relatively rare cases/gridcells where stress (tmask) and stepu (umask) are advanced
    without the other.  The 1d evp implementation was not addressing this issue, so skiptcell was added
    to the 1d evp (similar to skipucell) to mask out cells separately for stress and stepu.  This
    fixed a few non bit-for-bit cases in testing.
    
    - Cleaned up some indentation and other minor issues in 1d evp.
    
    - Updated the evp_algorithm log output in ice_init.
    apcraig committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    1262455 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2021

  1. Merge pull request #17 from apcraig/evp1da

    Fix evp 1d masking issues
    srethmeier authored Jul 17, 2021
    Configuration menu
    Copy the full SHA
    064bc47 View commit details
    Browse the repository at this point in the history
  2. Some minor revisions in the documentation as suggested by @apcraig (C…

    …ICE-Consortium#568 (review)) plus some additional minor spelling corrections.
    srethmeier committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    1869e93 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    92c49bb View commit details
    Browse the repository at this point in the history