Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Time Manager #566

Merged
merged 17 commits into from
Mar 16, 2021
Merged

Update Time Manager #566

merged 17 commits into from
Mar 16, 2021

Commits on Feb 24, 2021

  1. Initial refactor of time manager

    - nyr, month, mday, sec are the new time manager prognostic variables
    - time is renamed to timesec and is a diagnostic, not prognostic variable
    - remove time_forc, was not needed or being used anyway
    - refactor ice_calendar, use calendar_type to define calendar after initialization
    - add several new subroutines to ice_calendar including
      - advance_time = handles advancing the model a timestep
      - calendar_compute_elapsed_days = compute elapsed days since 0000-01-01
      - calendar_compute_days_between = compute days between two yyyy-mm-dd dates
      - calendar_set_date_from_timesecs = support conversion of timesecs to date for binary restarts
      - calendar = same behavior as old method, just no more argument
    - add month_init, day_init, sec_init, and npt_unit to namelist
    - this is bit-for-bit with f5f487f on cheyenne with full test suite, manual checks of log files
      were done to verify.  restart files are not identical due to changes in files saved
    - old restarts should be backwards compatible
    - to advance the model a timestep, call advance_time() or update nyr, month, mday, sec and call calendar().
      subroutine calendar() will adjust the date values as needed (for instance, adding a million seconds to sec).
    apcraig committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    67b340f View commit details
    Browse the repository at this point in the history
  2. Add unit test for calendar

    apcraig committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    dcdb778 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a41b12f View commit details
    Browse the repository at this point in the history
  4. update calchk unit test

    apcraig committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    7544294 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    de83858 View commit details
    Browse the repository at this point in the history
  6. Add calc_timesteps to compute timesteps from npt and npt_unit

    Modify set_nml.run* to use new npt_unit and npt
    Add calc_timesteps test to calchk unit test
    Update standalone model to call calc_timesteps during initialization
      and after restarts are read
    apcraig committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    ac4a7e9 View commit details
    Browse the repository at this point in the history
  7. Update JRA55_data implementation

    Update computation of fyear to support cycling correctly with new definition on nyr
    Modify restart run lengths to be days instead of timesteps
    Add debugging to ice_forcing.F90
    Add timer for forcing
    apcraig committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    2ff40b1 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d71f3c9 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    50f628c View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. Update CICE for coupling with RASM with new time manager

    - Update drivers/mct/cesm1/CICE_InitMod.F90 and CICE_RunMod.F90
      - use advance_timestep
      - get rid of use of time variable, shift to nyr, month, mday, sec
      - update calendar call
      - update usage of year_init
    - Add section in user guide about coupling with new time manager
    - Fix stuff unrelated to time manager
      - Fix bug in wght_file diagnostic in ice_domain.F90, was written before defined
      - Fix bug in bathymetry settings when max kmt is greater than hardcoded 40 levels
      - Add a few missing namelist variables recently added to documentation
    apcraig committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    d17b86d View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2021

  1. clean up old code

    apcraig committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    de335f4 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. update documentation

    apcraig committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    7723bef View commit details
    Browse the repository at this point in the history
  2. update ice_calendar comments

    apcraig committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    d6e9716 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. Configuration menu
    Copy the full SHA
    780cd10 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    444a29c View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2021

  1. Configuration menu
    Copy the full SHA
    9e898e4 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. Update prognostic calendar variables to myear, mmonth, mday, msec.

    They were nyr, month, mday, sec.  The "m" in front means model and it
    creates more unique names in the source code than year, month, day, sec
    which can be hard to grep for because there are so many matches.
    
    This is bit-for-bit on a full test suite on cheyenne.
    apcraig committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    b25e5f5 View commit details
    Browse the repository at this point in the history