-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make JRA55 default forcing dataset #533
Merged
Merged
Commits on Dec 21, 2020
-
Update test suite, add complete set of jra55 tests.
jra55 tests for different grids gx3 uses jra55_gx3 gx1 uses jra55_gx1 tx1 is already using jra55 by default (no changes to tests required) gbox* uses internal forcing, no jra55 data (no changes to tests required) remove ocn_data_dir='default' and bgc_data_dir='default' in set_nml.jra55* files because it causes the bgc tests to fail. the bgc tests work with WOA bgc forcing data with jra55 physics forcing data. iobinary tests must use the old gx3 binary forcing, the jra55_gx3 netcdf data causes an abort because iobinary is tested with netcdf turned off. the old gx3 data is NCAR_bulk in binary format. alt01 with jra55 uses the alt01a setting. the difference is that use_leap_years is set to false in alt01a. It's set to true by default in the jra55 datasets.
Configuration menu - View commit details
-
Copy full SHA for 90d0bc5 - Browse repository at this point
Copy the full SHA 90d0bc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d748583 - Browse repository at this point
Copy the full SHA d748583View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9904986 - Browse repository at this point
Copy the full SHA 9904986View commit details -
Update options and tests to make JRA55 the default
set_nml.gx3 and set_nml.gx1 are now JRA55 by default get rid of set_nml.jra55* files add set_nml.gx3ncarbulk and set_nml.gx1coreii which invokes prior forcing datasets modify the test suites to do identical tests but with new options, compare to prior implementation by creating a renamed regression baseline via a script and links to generate the new names. Use zz* for the new set_nml options temporarily just to make it easy to generate the new links (the zz ensures the new options are last in the list by alphabet) chmod -x all set_* files for consistency
Configuration menu - View commit details
-
Copy full SHA for b99f510 - Browse repository at this point
Copy the full SHA b99f510View commit details -
this is done as a clean separate step so new baselines can be established to continue to evolve the test cases and allow regression testing
Configuration menu - View commit details
-
Copy full SHA for 97b11ea - Browse repository at this point
Copy the full SHA 97b11eaView commit details
Commits on Dec 22, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0eeefcf - Browse repository at this point
Copy the full SHA 0eeefcfView commit details
Commits on Dec 23, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9f3cd99 - Browse repository at this point
Copy the full SHA 9f3cd99View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.