Issue333 #337
Merged
Issue333 #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 26, 2019 17:44
…here a data point falls exactly half way between 2 critical T-values.
…e script to use less memory.
|
Odd. Every test on Travis-CI failed to build, with the failures being related to I didn't make any edits to the source code, so I doubt these failures are a result of something that I did... |
|
I restarted travis on this PR and it failed again the same way. I am going to run a few other tests. |
apcraig
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
Short (1 sentence) summary of your PR:
Fix a bug in the CICE QC script that occurs only when a data point falls exactly half way between 2 critical T-values.
Developer(s):
@mattdturner
Suggest PR reviewers from list in the column to the right.
Please copy the PR test results link or provide a summary of testing completed below.
I tested the QC script by generating identical datasets for a 5 year simulation. I also tested it using the data provided by @phil-blain in issue qc environment setup #333
How much do the PR code changes differ from the unmodified code?
Does this PR create or have dependencies on Icepack or any other models?
Does this PR add any new test cases?
Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
Please provide any additional information or relevant details below:
-There are also a few changes to reduce the memory footprint of the script.
memory_profilerpackage in Python, the script now requires5.25 GBof memory in order to run the test for a full 5-yeargx1simulation.-This PR addresses Issue qc environment setup #333