Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Compare_angle_3 overload and missing global functions / doc #8337

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

MaelRL
Copy link
Member

@MaelRL MaelRL commented Jul 4, 2024

Summary of Changes

#8170 added an overload, but the Kernel concept was not updated.

The PR adds the doc, tests, global functions, and an additional overload.

Release Management

  • Affected package(s): Kernel_23
  • Issue(s) solved (if any): -
  • Feature/Small Feature (if any): -
  • License and copyright ownership: no change

@lrineau
Copy link
Member

lrineau commented Jul 8, 2024

/build:doc

Copy link

github-actions bot commented Jul 8, 2024

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8337/doc/Manual/index.html

@lrineau

This comment was marked as off-topic.

This comment was marked as off-topic.

@sloriot
Copy link
Member

sloriot commented Jul 15, 2024

Successfully tested in CGAL-6.0-Ic-286

@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jul 16, 2024
@lrineau lrineau self-assigned this Jul 16, 2024
@sloriot sloriot merged commit 4fbb66a into CGAL:master Jul 23, 2024
9 checks passed
@sloriot sloriot removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants