[WIP] CGAL 3D constrained Delaunay triangulation #8186

lrineau · 2024-05-06T07:59:57Z

Summary of Changes

Doc prototype:

package overview: https://cgal.github.io/8186/v1/Manual/packages.html#PkgCT_3
ref manual: https://cgal.github.io/8186/v1/Constrained_triangulation_3/group__PkgCT__3Ref.html

This is a work in progress for now. Stay tuned...

TODO list

move added files from Triangulation_3/ to CDT_3/

Release Management

Affected package(s):
Issue(s) solved (if any): fix #0000, fix #0000,...
Feature/Small Feature (if any):
Link to compiled documentation (obligatory for small feature) wrong link name to be changed
License and copyright ownership:

The explanation of the bug: `split_graph_into_polylines` can reverse the orientation of a polygon

Actually, that was not a bug. The issue is that the simplex traverse in 2D is currently buggy. With a bbox, that passes.

The data set was not coplanar, but a few vertices were missing from the initial CDT.

``` 2>C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.35.32215\include\type_traits(143,19): error C2338: static_assert failed: 'Calling declval is ill-formed, see N4917 22.2.6 [declval]/2.' 2>C:\GitHub\cgal\Triangulation_3\test\Triangulation_3\cdt_3_from_off.cpp(311): message : see reference to function template instantiation 'Segment &&std::declval<Segment>(void) noexcept' being compiled 2>C:\GitHub\cgal\Triangulation_3\test\Triangulation_3\cdt_3_from_off.cpp(311,57): message : see reference to function template instantiation 'std::vector<std::vector<Point,std::allocator<Point>>,std::allocator<std::vector<Point,std::allocator<Point>>>> segment_soup_to_polylines<_Ty&>(Range_of_segments)' being compiled ```

There was a warning: ``` Triangulation_3/include/CGAL/Constrained_Delaunay_triangulation_3.h:1841:5: warning: this statement may fall through [-Wimplicit-fallthrough=] [build] 1841 | } // dim 2 [build] | ^ ``` and for once that was a warning about a real bug!

The files are even repaired on the fiy.

For the moment, I selected: - num_vertices < 10000 and - "solid" As for the meaning of "solid", quoting Zhou, Qingnan, et al. "Mesh arrangements for solid geometry." ACM Transactions on Graphics (TOG) 35.4 (2016): 1-15.: > Solid meshes are free of self-intersections, degenerate triangles > or duplicate triangles, and their generalized winding number field > is either zero or one.

... instead of applying random selection of buckets.

`Surface_mesh::collect_garbage` uses swaps, and this it modifies the order of elements of the mesh.

@MaelRL

@MaelRL This is the bug of Saddle-1CC.

so that I can introduce new ones more easily

this one is to dump the input surface with the extra Steiner points of the conforming. And add a --help option as well.

Check that the triangulation is still Delaunay after the conforming.

github-actions · 2024-07-09T15:31:23Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8186/v1/Manual/index.html

`Constrained_Delaunay_triangulation_3<Traits>` is the default.

…-lrineau

… input

…-lrineau

lrineau · 2024-09-15T20:38:18Z

/force-build:wip

github-actions · 2024-09-15T20:41:37Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8186/wip/Manual/index.html

ImperatorS79 · 2024-09-30T07:32:04Z

Hello,

I allow myself to comment here, but the interface of this class is not similar to the Constrained_Delaunay_Triangulation_2. As a user of CGAL, I would have expected to be able to tetrahedralize a set of points in 3D, then insert some constraints with a function like insert_constraints(), as well as being able to remove constrained facets.

When I read the currently built documentation, it seems that this class is intended to generate a tetrahedralization from scratch which will conform to the constraints. While this is intersting, IMHO users would expect Constrained_Delaunay_Triangulation_2 and Constrained_Delaunay_Triangulation_3 to behave in the same way (I must said I am looking for a class Constrained_Delaunay_Triangulation_3 which behave like Constrained_Delaunay_Triangulation_2). Do you plan to add those functionalities to this class later ?

EDIT: I understand this is WIP, but I prefer to ask while the code is not in the main repo yet.

lrineau added 30 commits September 25, 2023 17:58

fix cheese18 --merge-facets

3d38521

The explanation of the bug: `split_graph_into_polylines` can reverse the orientation of a polygon

fix the bug of cheese23.off

e0a3467

Actually, that was not a bug. The issue is that the simplex traverse in 2D is currently buggy. With a bbox, that passes.

dump outputs with --merge-facets

a273c75

better fix for cheese23

53e4783

The data set was not coplanar, but a few vertices were missing from the initial CDT.

insert the "bbox" iff cdt.dimension()==2

d6af372

those debug function must be const

28f675a

error message about unknown options

87fdd90

unless CGAL_TRIANGULATION_CHECK_EXPENSIVE

bf2948d

remove unused variable

8a82fc5

fix a bug in dimension 2

713217a

There was a warning: ``` Triangulation_3/include/CGAL/Constrained_Delaunay_triangulation_3.h:1841:5: warning: this statement may fall through [-Wimplicit-fallthrough=] [build] 1841 | } // dim 2 [build] | ^ ``` and for once that was a warning about a real bug!

oformat is in CGAL::IO::

dbbf8cb

fix a warning

5ab8db3

fix code when CGAL_NDEBUG or NDEBUG is defined

ad83ce5

add another selection of HexiCosPot

4998da4

Allow to open more that OFF files

bd4d711

The files are even repaired on the fiy.

with --ratio 0.1, iterate on all buckets in order

01d64ff

... instead of applying random selection of buckets.

allow the compilation with Epeck

4829813

remove m.collect_garbage();

f9d4c34

`Surface_mesh::collect_garbage` uses swaps, and this it modifies the order of elements of the mesh.

fix another bug in construct_Steiner_point

780f1ee

@MaelRL This is the bug of Saddle-1CC.

Replace ERROR by NOTE because those were not errors

3cf28af

--ratio: Adjust nb_of_bucket when only one face is skipped

9e305fc

reimplement brute_force_border_3_of_region

c6545a0

fix typo

f9f6195

fix the number of added vertices in a cavity

b8e8d74

factorize the handling of options

87be4b4

so that I can introduce new ones more easily

more options

f0ae047

add another option

8dccbf8

this one is to dump the input surface with the extra Steiner points of the conforming. And add a --help option as well.

extra assertion

0d71b70

Check that the triangulation is still Delaunay after the conforming.

add dependencies

72200ca

MaelRL added Not yet approved The feature or pull-request has not yet been approved. Feature CHANGES.md not updated labels Jul 9, 2024

lrineau marked this pull request as ready for review July 9, 2024 21:13

lrineau marked this pull request as draft July 9, 2024 21:14

lrineau self-assigned this Jul 22, 2024

lrineau added 10 commits July 25, 2024 18:14

rename template parameters

8920af9

doc improvements after review

caf7c3a

remove Default_constrained_Delaunay_triangulation_3

21e72b4

`Constrained_Delaunay_triangulation_3<Traits>` is the default.

Merge remote-tracking branch 'cgal/master' into Triangulation_3-CDT_3…

4e7ff3d

…-lrineau

cdt_3 plugin

8eaabab

fix memory leaks

8ba8d99

simplification

1d0604c

new version of the cdt_3 plugin: can take a colorized surface_mesh as…

34792e4

… input

Merge remote-tracking branch 'cgal/master' into Triangulation_3-CDT_3…

647686a

…-lrineau

the basic viewer bug is now fixed in master

093d400

This comment was marked as outdated.

Sign in to view

This comment was marked as duplicate.

Sign in to view

This comment was marked as outdated.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] CGAL 3D constrained Delaunay triangulation #8186

[WIP] CGAL 3D constrained Delaunay triangulation #8186

lrineau commented May 6, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

lrineau commented Sep 15, 2024

github-actions bot commented Sep 15, 2024

ImperatorS79 commented Sep 30, 2024 •

edited

Loading

[WIP] CGAL 3D constrained Delaunay triangulation #8186

Are you sure you want to change the base?

[WIP] CGAL 3D constrained Delaunay triangulation #8186

Conversation

lrineau commented May 6, 2024 • edited Loading

Summary of Changes

TODO list

Release Management

github-actions bot commented Jul 9, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

lrineau commented Sep 15, 2024

github-actions bot commented Sep 15, 2024

ImperatorS79 commented Sep 30, 2024 • edited Loading

lrineau commented May 6, 2024 •

edited

Loading

ImperatorS79 commented Sep 30, 2024 •

edited

Loading