Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] CGAL 3D constrained Delaunay triangulation #8186

Draft
wants to merge 444 commits into
base: master
Choose a base branch
from

Conversation

lrineau
Copy link
Member

@lrineau lrineau commented May 6, 2024

Summary of Changes

Doc prototype:

This is a work in progress for now. Stay tuned...

TODO list

  • move added files from Triangulation_3/ to CDT_3/

Release Management

  • Affected package(s):
  • Issue(s) solved (if any): fix #0000, fix #0000,...
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership:

The explanation of the bug:
`split_graph_into_polylines` can reverse the orientation of a polygon
Actually, that was not a bug. The issue is that the simplex traverse
in 2D is currently buggy. With a bbox, that passes.
The data set was not coplanar, but a few vertices were missing from the
initial CDT.
```
2>C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.35.32215\include\type_traits(143,19): error C2338: static_assert failed: 'Calling declval is ill-formed, see N4917 22.2.6 [declval]/2.'
2>C:\GitHub\cgal\Triangulation_3\test\Triangulation_3\cdt_3_from_off.cpp(311): message : see reference to function template instantiation 'Segment &&std::declval<Segment>(void) noexcept' being compiled
2>C:\GitHub\cgal\Triangulation_3\test\Triangulation_3\cdt_3_from_off.cpp(311,57): message : see reference to function template instantiation 'std::vector<std::vector<Point,std::allocator<Point>>,std::allocator<std::vector<Point,std::allocator<Point>>>> segment_soup_to_polylines<_Ty&>(Range_of_segments)' being compiled
```
There was a warning:
```
Triangulation_3/include/CGAL/Constrained_Delaunay_triangulation_3.h:1841:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
[build]  1841 |     } // dim 2
[build]       |     ^
```
and for once that was a warning about a real bug!
The files are even repaired on the fiy.
For the moment, I selected:
  - num_vertices < 10000 and
  - "solid"

As for the meaning of "solid", quoting Zhou, Qingnan, et al.
"Mesh arrangements for solid geometry."
ACM Transactions on Graphics (TOG) 35.4 (2016): 1-15.:
> Solid meshes are free of self-intersections, degenerate triangles
> or duplicate triangles, and their generalized winding number field
> is either zero or one.
... instead of applying random selection of buckets.
`Surface_mesh::collect_garbage` uses swaps, and this it modifies the
order of elements of the mesh.
That was more difficult than I expected!
@lrineau

This comment was marked as outdated.

This comment was marked as outdated.

- rename the meta-function, and the type alias
- rename the template parameter `Geom_traits` to `Traits`
@lrineau

This comment was marked as outdated.

This comment was marked as outdated.

lrineau

This comment was marked as outdated.

lrineau

This comment was marked as outdated.

@lrineau

This comment was marked as off-topic.

This comment was marked as outdated.

@lrineau

This comment was marked as outdated.

This comment was marked as outdated.

@lrineau
Copy link
Member Author

lrineau commented Jul 9, 2024

/force-build:v1

after cefd1e1

Copy link

github-actions bot commented Jul 9, 2024

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8186/v1/Manual/index.html

@MaelRL MaelRL added Not yet approved The feature or pull-request has not yet been approved. Feature CHANGES.md not updated labels Jul 9, 2024
@lrineau lrineau marked this pull request as ready for review July 9, 2024 21:13
@lrineau lrineau marked this pull request as draft July 9, 2024 21:14
@lrineau lrineau self-assigned this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHANGES.md not updated Feature Not yet approved The feature or pull-request has not yet been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants