Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use workspace.dependencies to uniformly manage the dependent versions of all packages #263

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

0xbillw
Copy link
Member

@0xbillw 0xbillw commented Nov 16, 2023

  • All dependencies of member packages are changed to use inherited from workspace, except;
  • the parity-scale-codec crate don't change yet, because the dependency renaming seens have a bug in workspace dependency inheriting (that bug will be reproducible, I'll submit a issue to cargo repository);
  • and the both package ring and webpki under path utils nothing to change;
  • the only package that can affect dependency changes is pallet-file-bank, removed dependency parking_lot, I think it should not be used on Pallet, and after removal, there is no problem with compilation.

@0xbillw 0xbillw requested a review from ytqaljn November 16, 2023 07:46
@0xbillw 0xbillw merged commit c973c19 into main Nov 16, 2023
1 check passed
@0xbillw 0xbillw deleted the workspace-deps branch November 16, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants