BibAuthority: people collection #162
Conversation
jochenklein
force-pushed
the
cds-bibauthority-people
branch
3 times, most recently
from
0747b1c
to
cb216c3
Compare
jochenklein
changed the title
jochenklein
force-pushed
the
cds-bibauthority-people
branch
24 times, most recently
from
99b5de6
to
ed92a1d
Compare
jochenklein
force-pushed
the
cds-bibauthority-people
branch
from
ed92a1d
to
075d342
Compare
jochenklein
force-pushed
the
cds-bibauthority-people
branch
from
075d342
to
b25bbbd
Compare
|
Do diff with production code before merging |
| author in query_author_source("") if | ||
| author.get("cernccid") and author.get("inspireid") | ||
| ] | ||
| ) |
There was a problem hiding this comment.
This needs to be changed somehow, we shouldn't have complex function calls inside a config file specially if they relay in external services which might or might not work.
There was a problem hiding this comment.
Maybe you can use this to build the dictionary https://github.com/CERNDocumentServer/invenio/blob/prod/modules/miscutil/lib/containerutils.py#L280
| pass | ||
|
|
||
|
|
||
| class Mapper: |
There was a problem hiding this comment.
Maybe is better to use new style classes https://docs.python.org/2/reference/datamodel.html#new-style-and-classic-classes
jochenklein
force-pushed
the
cds-bibauthority-people
branch
2 times, most recently
from
4471130
to
4cdeab9
Compare
* Adds config, mapper, and utils which are used by the command line interface (CLI) 'bibauthority_people' and the bibsched tasklet 'bst_bibauthority_people_updater'. Signed-off-by: Jochen Klein <[email protected]>
* Adds a command line interface for mapping all CERN LDAP records to MARC 21 authority records, writing to MARCXML, and uploading to CDS. * Adds CLI to makefile. Signed-off-by: Jochen Klein <[email protected]>
* Adds bibsched tasklet which updates the CERN people collection on CDS. * Adds tasklet to makefile. Signed-off-by: Jochen Klein <[email protected]>
jochenklein
force-pushed
the
cds-bibauthority-people
branch
from
4cdeab9
to
b077038
Compare
|
I see a lot of references to CERN. Can you confirm that this shall not be an invenio PR? @egabancho @switowski |
|
Confirmed, but I don't remember why I wrote this "note to self" |
Adds a command line interface and bibsched tasklet to create and update the CERN people collection used by CDS. (Requires #140)