Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: [dev-8409] dashboard filter refactor #1390

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

joshlacey
Copy link
Collaborator

@joshlacey joshlacey commented Jul 9, 2024

To configure Dashboard filters you now need to drag and drop a filter widget to the visualizations panel and then select the tools icon to configure.

Testing Instructions are in the ticket.

@joshlacey
Copy link
Collaborator Author

@mpallansch this is waiting on #1363 to get merged into dev and then when it's rebased we should only see 30 something files changed.

@joshlacey joshlacey force-pushed the feature/dev-8409-dashboard-filter-refactor branch from b2cd17e to 7daf02e Compare July 9, 2024 16:52
Copy link
Collaborator

@mpallansch mpallansch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback on testing:

  1. Existing dashboards that already have filters still seem to work, but I'm unable to edit the filters in the editor panel
  2. The reason the filter-dropdown drag'n'drop element was created in the first place was to repeat filters throughout dashboard, so users didn't have to scroll to the top of long dashboards every time they need to change something. In this setup, they would have to input the filter configuration every time it needed to show and any time they need to change it, they would need to change all instances.
  3. It looks like new filters have a blank option in the dropdown

@joshlacey
Copy link
Collaborator Author

@mpallansch

  1. So legacy configuration is supported but I don't think we should support the edit capability beyond what can be done via the Advanced Editor. changes in dev-8574 should make editing easier. What that would entail is user drags over a filter editor and then goes into advanced editor and assigns all of the indexes of the dashboard.shared filters to that new visualization. It should be done this way as I'm not sure how many edge cases we would run into by trying to do this manually.
  2. I'm not sure I follow the issue?
  3. I'll fix this bug, thanks for catching

@joshlacey joshlacey force-pushed the feature/dev-8409-dashboard-filter-refactor branch 2 times, most recently from 1a2b925 to b7a15ed Compare July 11, 2024 19:02
@mpallansch
Copy link
Collaborator

@mpallansch

  1. So legacy configuration is supported but I don't think we should support the edit capability beyond what can be done via the Advanced Editor. changes in dev-8574 should make editing easier. What that would entail is user drags over a filter editor and then goes into advanced editor and assigns all of the indexes of the dashboard.shared filters to that new visualization. It should be done this way as I'm not sure how many edge cases we would run into by trying to do this manually.
  2. I'm not sure I follow the issue?
  3. I'll fix this bug, thanks for catching
  1. How would they go about removing their existing filters to recreate them in the current system? Or would they have to recreate the entire dashboard config if they have filters and need to update them?
  2. We can have a meeting to discuss if that's easier, but the need is to be able to configure a dropdown filter a single time, then have it show multiple times on the dashboard

@joshlacey joshlacey force-pushed the feature/dev-8409-dashboard-filter-refactor branch 2 times, most recently from db33d6f to 8bd3fef Compare July 16, 2024 13:50
@joshlacey joshlacey force-pushed the feature/dev-8409-dashboard-filter-refactor branch from 8bd3fef to 8f06072 Compare July 16, 2024 14:27
@joshlacey joshlacey marked this pull request as ready for review July 16, 2024 15:58
@mpallansch mpallansch merged commit f21a540 into dev Jul 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants