-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: [dev-8409] dashboard filter refactor #1390
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mpallansch this is waiting on #1363 to get merged into dev and then when it's rebased we should only see 30 something files changed. |
b2cd17e
to
7daf02e
Compare
mpallansch
reviewed
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback on testing:
- Existing dashboards that already have filters still seem to work, but I'm unable to edit the filters in the editor panel
- The reason the filter-dropdown drag'n'drop element was created in the first place was to repeat filters throughout dashboard, so users didn't have to scroll to the top of long dashboards every time they need to change something. In this setup, they would have to input the filter configuration every time it needed to show and any time they need to change it, they would need to change all instances.
- It looks like new filters have a blank option in the dropdown
|
1a2b925
to
b7a15ed
Compare
|
db33d6f
to
8bd3fef
Compare
8bd3fef
to
8f06072
Compare
mpallansch
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To configure Dashboard filters you now need to drag and drop a filter widget to the visualizations panel and then select the tools icon to configure.
Testing Instructions are in the ticket.