-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Hikes immediately #83
base: main
Are you sure you want to change the base?
Conversation
if (model.startsAt.isBefore(DateTime.now() | ||
.subtract(Duration(minutes: 1)))) { | ||
navigationService | ||
.showSnackBar("Enter a valid date and time!"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of snack bar, I guess it would be better to add validations in the fields itself. When keyboard is on snackbar popups aren't displayed well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! So should I close the keyboard upon this error and then show snackbar or validate the field itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validating fields would be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any progress? @ItsAdityaKSingh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not quite! Got busy in academics. Gonna run through the required changes requested and update soon :)
Fixes #82
Describe the changes you have made in this PR - Reduced a minute for creating hike immediately. Also changed a snack bar message
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.