Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new gt4py tag #994

Merged
merged 9 commits into from
Sep 11, 2024
Merged

new gt4py tag #994

merged 9 commits into from
Sep 11, 2024

Conversation

nfarabullini
Copy link
Contributor

new tag --> icon4py_20240903

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-09-11 07:50 UTC

@jonasjucker
Copy link
Contributor

launch jenkins py-gt4py

@jonasjucker
Copy link
Contributor

I will merge if tests ar green

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢py-gt4py-spack_info
🟢py-gt4py-spack_spec
🔴 system test
Test
🟢[email protected]
🟢[email protected]
🟢[email protected]
🔴[email protected]

@nfarabullini
Copy link
Contributor Author

launch jenkins py-gt4py

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢py-gt4py-spack_info
🟢py-gt4py-spack_spec
🔴 system test
Test
🟢[email protected]
🟢[email protected]
🔴[email protected]

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢py-gt4py-spack_info
🟢py-gt4py-spack_spec
🔴 system test
Test
🟢[email protected]
🟢[email protected]
🔴[email protected]

edopao
edopao reviewed Sep 9, 2024
View reviewed changes
repos/c2sm/packages/py-icon4py/package.py Outdated Show resolved Hide resolved
repos/c2sm/packages/py-gt4py/package.py Outdated Show resolved Hide resolved
@nfarabullini
Copy link
Contributor Author

launch jenkins py-gt4py

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢py-gt4py-spack_info
🟢py-gt4py-spack_spec
🔴 system test
Test
🟢[email protected]
🟢[email protected]
🔴[email protected]

@nfarabullini
Copy link
Contributor Author

launch jenkins py-gt4py

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢py-gt4py-spack_info
🟢py-gt4py-spack_spec
🔴 system test
Test
🟢[email protected]
🟢[email protected]
🔴[email protected]

@edopao
Copy link
Contributor

edopao commented Sep 11, 2024

launch jenkins py-gt4py

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢py-gt4py-spack_info
🟢py-gt4py-spack_spec
🟢 system test
Test
🟢[email protected]
🟢[email protected]
🟢[email protected]

@nfarabullini nfarabullini merged commit b152ee3 into main Sep 11, 2024
4 checks passed
@nfarabullini nfarabullini deleted the new_september_tag_addition branch September 11, 2024 07:49
@dominichofer
Copy link
Contributor

This PR changes the tests of py-icon4py and they fail:
https://jenkins-mch.cscs.ch/job/Spack/job/spack_PR/1720/artifact/log/balfrin/system_test/install_py_icon4py_version_0_0_12-py-icon4py_@_0.0.12_gcc_%[email protected]
https://jenkins-mch.cscs.ch/job/Spack/job/spack_PR/1721/artifact/log/install_py-icon4py.log
This was missed because the tests were never executed. My advice, always run "launch jenkins all".
Until this is fixed I'm going to revert this PR because it is blocking several other PRs.
@nfarabullini can you please have an other look at it? Thank you.

dominichofer added a commit that referenced this pull request Sep 11, 2024
@dominichofer
Revert "new gt4py tag (#994)"
4fbf3f7 
This reverts commit b152ee3.
@dominichofer dominichofer mentioned this pull request Sep 11, 2024
Merged
dominichofer added a commit that referenced this pull request Sep 11, 2024
@dominichofer
Revert "new gt4py tag (#994)" (#997)
ed8f9de 
This reverts commit b152ee3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edopao edopao edopao left review comments

@jonasjucker jonasjucker jonasjucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nfarabullini @jonasjucker @jenkins-apn @edopao @dominichofer