Implementation of issue number 6 #27
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This is a visually lovely PR, @ruhneb2004! I love the footer idea so they can see the custom state on every page! I suggest you change your message that currently uses the browser's native alert window to something with prettier UI and smoother UX, such as Daisy UI's modal component. Then you can provide the link to the check-in issue as a link or a button, whatever you think makes more sense. Make sure to rebase on recent commits to |
|
The above commit was not intended. I am really new to github and it's workings. Sorry! |
|
Changed the alert component to the daisy ui modal component. The ones who have checkedIn can now see their contract in etherscan.io and the ones who have not done the challenge can no visit the issue#10 by clicking the link. the ones who have checkedIn
the ones who have not checkedIn
Everything else is same! |
Totally okay! Learning how to use Your updates are looking really nice, @ruhneb2004! Do you want to push it one step further by playing with the styling of the modal so the buttons are more centered and spaced within the width of the container? |
|
The github is somewhat making sense now, I have done some little projects and stuff but I haven't done this sort of stuff before, so this is really a cool learning experience. And for the modal, I would love to give it an another try |
|
I have adjusted the spacing of the buttons and some padding for the text as shown below for the modal 
Earlier the styling was not adjusted to the light mode and the text inside the logo was not visible for the batch member logo in the light mode, I have also fixed those issues. 
TodoAfter the list of the batch members are out to display I am thinking about making the batch member logo point to our list of the builders |
There was a problem hiding this comment.
Loving the updated styling on the modal! 🤩
The last step is to learn how to remove the accidental commits from this pull request before I merge. I had to do the same thing recently and found this Stack Overflow answer very useful. git can be scary, but visual tools like VS Code's interactive rebase make it easier to choose which commits to keep and which to drop!
Try it out and let us know how it goes 💪
…ng adjustment and button positioning in the modal
|
I learned something new today! I have removed all other commits apart from the one related to this issue. I hope this is what you were looking for @derrekcoleman 🤞 |
|
Great job, @ruhneb2004! Your git-fu has become stronger today 🥷 |
|
Haha! Thanks 😊 |
Description
Added a batch member logo on the left hand side of the footer, this will only appear if they are in the allowList. There is also a button on the right side of showing whether they have done the check In or not. If they have then on clicking the button they can see a alert showing the contract address they have deployed. If not then on click they will be redirected to the issue #10.
Additional Information
Related Issues
Closes #{10}
Your ENS/address: 0xBC428Bb80B1cc3C29164820528819Abf6b20cB88