Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Logo / title / subtitle #19

Merged
merged 3 commits into from
Aug 23, 2024
Merged

Conversation

0xzeze
Copy link
Contributor

@0xzeze 0xzeze commented Aug 16, 2024

Description

The following changes were made:

-Added a new batch logo.
-Updated the title to "Batch #8."
-Added a subtitle: "Learn Together!"
Ekran Resmi 2024-08-16 21 07 28

Ekran Resmi 2024-08-16 21 07 42

Please review the changes and provide any feedback.

Additional Information

Related Issues

_Closes #8

Your ENS/address: 0xfb8b972b0D1cF9BB242A40F7AEA8E9a1bF89E0E3

Copy link

vercel bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
batch8-buidlguidl-com-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 4:32pm

@derrekcoleman
Copy link
Collaborator

Thanks for your PR, @0xzeze! I appreciate that you linked to #8 for clarity. Your commit messages are also nicely labeled, making it easy to know what each one covers 👍

Regarding the PR process (not your code) for a moment, check out these parts of our CONTRIBUTING.md:

  1. Create a new branch with a descriptive name

and

  • Structure the description neatly to make it easy to consume by the readers. For example, you can include bullet points and screenshots instead of having one large paragraph.
  • Have a good commit message that summarises the work done.

Your PR is from 0xzeze:origin, which is less descriptive than something like 0xzeze:change-logo-and-title. Let's leave this as-is; something to keep in mind for the future.

You can still change your PR message here on GitHub. Please edit your original message to include a list of changes this PR makes and a screenshot previewing those changes. I personally agree with all of the advice in this video regarding descriptive PRs, even for small changes like this one.

Ping me after you update your PR message and we can get this merged 💪

@derrekcoleman derrekcoleman self-requested a review August 16, 2024 17:23
@derrekcoleman derrekcoleman linked an issue Aug 16, 2024 that may be closed by this pull request
@0xzeze
Copy link
Contributor Author

0xzeze commented Aug 16, 2024

Thanks for your PR, @0xzeze! I appreciate that you linked to #8 for clarity. Your commit messages are also nicely labeled, making it easy to know what each one covers 👍

Regarding the PR process (not your code) for a moment, check out these parts of our CONTRIBUTING.md:

  1. Create a new branch with a descriptive name

and

  • Structure the description neatly to make it easy to consume by the readers. For example, you can include bullet points and screenshots instead of having one large paragraph.
  • Have a good commit message that summarises the work done.

Your PR is from 0xzeze:origin, which is less descriptive than something like 0xzeze:change-logo-and-title. Let's leave this as-is; something to keep in mind for the future.

You can still change your PR message here on GitHub. Please edit your original message to include a list of changes this PR makes and a screenshot previewing those changes. I personally agree with all of the advice in this video regarding descriptive PRs, even for small changes like this one.

Ping me after you update your PR message and we can get this merged 💪

Hello,you can check now. Thank you and thanks for helping

@derrekcoleman derrekcoleman merged commit 13c17d3 into BuidlGuidl:main Aug 23, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3. Change the Logo / title / subtitle
2 participants